Ensure that the CSS file rebuilds if a new CSS variable is used from templates #17301
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/rebuild-css-vars
branch
from
ed9d4c4 to
5c76b49
Compare
RobinMalfait
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17288
This PR fixes an issue where changes in template files that only mark a new CSS variable as used was not causing the CSS file to rebuilds.
This also fixes a flaky integration test that was caused by a missing
awaitline on the final assertion (causing it to sometimes run the assertion in time while the test runner was still running).Test plan
Turns out we already had an integration test for this but it wasn't correctly running due to the missing await.