Fix sorting of classes that have undefined declarations #16995
Merged
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
chore/fix-sorting-of-undefined-decls
branch
from
d83e2ab to
a185861
Compare
philipp-spiess
commented
Mar 6, 2025
Comment on lines
+15069
to
+15073
| .text-sm { | ||
| font-size: var(--text-sm); | ||
| line-height: var(--tw-leading, var(--text-sm--line-height)); | ||
| } | ||
|
|
There was a problem hiding this comment.
This now uses alphabetical sorting becuase it has the same number of props as the arbitrary text classes
Comment on lines
16751
to
+16755
| font-size: var(--text-sm, .8755rem); | ||
| line-height: var(--text-sm--line-height, 1.255rem); | ||
| text-rendering: optimizeLegibility; | ||
| font-size: var(--text-sm, .875rem); | ||
| line-height: var(--tw-leading, var(--text-sm--line-height, 1.25rem)); |
There was a problem hiding this comment.
This diff is weird but that's because of lightning flatting. What happens ehre is the custom new text-sm utility is now rendered before the core text-sm. The new prop text-rendering: optimizeLegibility; is still added, the rest is intended behavior here since you can't overwrite core utilities.
RobinMalfait
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16973
Declaration values of
undefinedare an implementation detail and skipped when printing the CSS. Thus, these should not count towards the sort order at a..Test plan