Don’t replace _ in suggested theme keys
#16433
Merged
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/v4-underscore-theme-key-suggestions
branch
from
3fc4d9f to
4f06708
Compare
philipp-spiess
approved these changes
Feb 11, 2025
thecrypticace
force-pushed
the
feat/v4-underscore-theme-key-suggestions
branch
from
485ef8d to
5d6f195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailwindlabs/tailwindcss-intellisense#1184
The alpha and beta releases used
_in theme keys to represent a.. This meant we used--leading-1_5instead of--leading-1\.5to add utilities likeleading-1.5. We prefer the use of the escaped dot now but still want to make sure suggestions for the legacy key format still works as expected when surrounded by numbers.