Use long form <length> | <percentage> syntax for properties
#13660
+29
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using properties that declare the shorthand syntax `<length-percentage>` has a bug where two properties side-by-side e.g. `var(—foo)var(—bar)` invalidate the property value when it should not. Switching the `@property` definition to use the long form syntax `<length> | <percentage>` fixes this.
thecrypticace
force-pushed
the
fix/v4-property-syntax-ff-updates
branch
from
d88d9a5
to
85589ec
Compare
RobinMalfait
reviewed
May 8, 2024
There was a problem hiding this comment.
Should we update the <length-percentage> for gradient stops as well for completeness sake? 🤔
It looks like it's working, even though it's also generating concatenated vars:
.from-red-500 {
--tw-gradient-from: var(--color-red-500, #ef4444);
--tw-gradient-stops: var(--tw-gradient-via-stops, var(--tw-gradient-from)var(--tw-gradient-from-position), var(--tw-gradient-to)var(--tw-gradient-to-position))
}
|
Not sure what you mean? The variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox Nightly, when using properties that declare the shorthand syntax
<length-percentage>, there is a bug where two properties side-by-side e.g.var(—foo)var(—bar)invalidate the property value when it should not. Switching the@propertydefinition to use the long form syntax<length> | <percentage>fixes this.