Change dark selector so @apply
works correctly with pseudo elements
#13379
+44
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
class
strategy the dark mode selector is:is(.dark &)
. However, our code that handles hoisting pseudo elements outside of:is(…)
doesn't handle this properly when using@apply
.Given the following code:
You would end up with something like this:
The selector above is is equivalent to
.dark::-webkit-scrollbar-track
which is incorrect. We want a selector that is equivalent to.dark ::-webkit-scrollbar-track
.This PR changes the selector we define for dark mode to
&:is(.dark *)
. This is functionally equivalent to the previous selector and means we don't have to make any fixes inside@apply
's selector handling. As a result you'll end up with this CSS:Which is equivalent to
.dark ::-webkit-scrollbar-track
and thus works as expected.Fixes #13037