Ensure that arbitrary properties respect important configuration
#13353
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Mar 25, 2024
adamwathan
reviewed
Mar 25, 2024
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Reset letter spacing for form elements ([#13150](https://github.com/tailwindlabs/tailwindcss/pull/13150)) | |||
| - Fix missing `xx-large` and remove double `x-large` absolute size ([#13324](https://github.com/tailwindlabs/tailwindcss/pull/13324)) | |||
| - Don't error when encountering nested CSS unless trying to `@apply` a class that uses nesting ([#13325](https://github.com/tailwindlabs/tailwindcss/pull/13325)) | |||
| - Ensure that arbitrary properties respect the important configuration ([#13353](https://github.com/tailwindlabs/tailwindcss/pull/13353)) | |||
There was a problem hiding this comment.
I'd tweak this very slightly to:
Ensure that arbitrary properties respect
importantconfiguration
No "the", make important a code tag 👍
RobinMalfait
changed the title
important configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the important configuration was not respected for arbitrary properties.
If you have
important: "#app"in your configuration, then we expect the following CSS for an arbitrary property like[color:red]:But before this fix, the generated CSS looked like this instead:
Fixes: #13351