Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit letter spacing in form controls #13328

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Mar 22, 2024

(Same as #13150 but for v4)

Some browsers set letter-spacing: normal for form elements. This PR inherits letter-spacing styles for consistency since we also inherit other font attributes like family, style, line-height, etc…

@@ -189,6 +189,7 @@ textarea,
font: inherit; /* 1 */
font-feature-settings: inherit; /* 1 */
font-variation-settings: inherit; /* 1 */
letter-spacing: inherit; /* 1 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big difference compared to the v3 implementation is that the selector includes ::file-selector-button. But I tested this in various browsers and I don't see a difference so I think this good to merge 👍

@thecrypticace thecrypticace merged commit fee039d into next Mar 22, 2024
1 check passed
@thecrypticace thecrypticace deleted the feat/v4-inherit-letter-spacing branch March 22, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants