Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space between <figcaption> and <video> #339

Merged
merged 1 commit into from Mar 26, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Mar 24, 2024

Based off #313, ensure the video selector order is maintained so that the figure margin 0 overrides it correctly, allowing captions to be closer to the video.

Before:

image

After:

image

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-typography ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 8:05pm

@reinink reinink self-assigned this Mar 26, 2024
@reinink reinink changed the title Retain order of video selector with figure and captions Fix space between <figcaption> and <video> Mar 26, 2024
@reinink reinink changed the title Fix space between <figcaption> and <video> Fix space between <figcaption> and <video> Mar 26, 2024
@reinink reinink merged commit 69e3556 into tailwindlabs:master Mar 26, 2024
5 checks passed
@Archez Archez deleted the fix-figure-video branch March 26, 2024 14:23
@reinink
Copy link
Member

reinink commented Mar 26, 2024

Hey thanks for this contribution — this has been released as part of v0.5.11 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants