Skip to content

Make plugin Prettier v3 only + add 3rd-party plugin support #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 9, 2023

Conversation

thecrypticace
Copy link
Contributor

This PR enables support for all these plugins:

  • @ianvs/prettier-plugin-sort-imports
  • @prettier/plugin-pug
  • @shopify/prettier-plugin-liquid
  • @trivago/prettier-plugin-sort-imports
  • prettier-plugin-astro
  • prettier-plugin-css-order
  • prettier-plugin-jsdoc
  • prettier-plugin-organize-attributes
  • prettier-plugin-organize-imports
  • prettier-plugin-svelte

These plugins work, as previously, but they do not "officially" support Prettier v3. However, because they do still work we've kept support for them:

  • prettier-plugin-import-sort
  • prettier-plugin-style-order

The plugins that do not work are the following:

  • prettier-plugin-marko
  • prettier-plugin-twig-melody

Neither of these plugins work at present with Prettier v3 and support for them has been disabled.

As a part of this effort this plugin is now ESM only and requires Prettier v3+

Verified

This commit was signed with the committer’s verified signature.
MajorLift Jongsun Suh

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The CJS build only supports Prettier v2 and the ESM build only supports Prettier v3. This works out fine because Prettier v3 loads plugins using `import()` and Prettier v2 loads plugins using `require()`.
@thecrypticace thecrypticace merged commit 2a7e327 into main Aug 9, 2023
@thecrypticace thecrypticace deleted the feat/v3-plugins branch August 9, 2023 15:50
bronisMateusz pushed a commit to bronisMateusz/prettier-plugin-tailwindcss-drupal that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant