Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React 19 support #3543

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Add React 19 support #3543

merged 4 commits into from
Oct 25, 2024

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where @headlessui/react was not compatible with React 19.

We made sure that accessing refs is safe and works in React 18 and React 19. We also made sure to include React 19 as a valid version in the peer dependencies. For now, we also allowed the RC versions of React and React DOM.

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
This makes it work in both React 18 and React 19

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 1:50pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 1:50pm

Verified

This commit was signed with the committer’s verified signature.
RobinMalfait Robin Malfait
@RobinMalfait RobinMalfait enabled auto-merge (squash) October 25, 2024 13:49
@RobinMalfait RobinMalfait merged commit 8814b0e into main Oct 25, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/make-react-19-compatible branch October 25, 2024 13:50
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Dec 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@headlessui/react](https://github.com/tailwindlabs/headlessui) ([source](https://github.com/tailwindlabs/headlessui/tree/HEAD/packages/@headlessui-react)) | dependencies | minor | [`2.1.10` -> `2.2.0`](https://renovatebot.com/diffs/npm/@headlessui%2freact/2.1.10/2.2.0) |

---

### Release Notes

<details>
<summary>tailwindlabs/headlessui (@&#8203;headlessui/react)</summary>

### [`v2.2.0`](https://github.com/tailwindlabs/headlessui/blob/HEAD/packages/@&#8203;headlessui-react/CHANGELOG.md#220---2024-10-25)

[Compare Source](https://github.com/tailwindlabs/headlessui/compare/@headlessui/react@v2.1.10...@headlessui/react@v2.2.0)

##### Added

-   Add React 19 support ([#&#8203;3543](tailwindlabs/headlessui#3543))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS41Ny4yIiwidXBkYXRlZEluVmVyIjoiMzkuNTcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/377
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant