Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space between <figcaption> and <pre> #313

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

reinink
Copy link
Member

@reinink reinink commented Aug 30, 2023

Fixes #304

This PR fixes a spacing issue when putting a code block within a <figure>, where the margin on the <pre> wasn't being removed due to an ordering issue. This is a similar issue to #267.

By moving the figure styles to the end, the figure > * margin reset now takes priority over the specific element margin styles.

Before:

image

After:

image

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-typography ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 3:37pm

@reinink reinink merged commit ee884f3 into master Aug 30, 2023
@reinink reinink deleted the figure-pre-margin-fix branch August 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much space between figcaption and code block (pre)
1 participant