Split serde-de tests into several files and add new serde-se tests #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for sequences occupies over 4000 lines of code. Tests for enums occupies about 1000 lines of code. Since these tests are loosely related, it makes sense to separate them into separate files to speed up compilation
After moving tests to separate files indentation level was lowered, so some reformatting is needed
Mingun
force-pushed
the
reorganize-tests
branch
from
13f9ec2
to
a2060e9
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 64.36% 64.47% +0.10%
==========================================
Files 36 36
Lines 17343 17315 -28
==========================================
+ Hits 11162 11163 +1
+ Misses 6181 6152 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly reorganizes out test suite:
serde-de.rsbecame too big and because it's recompiled after each change in serde's part of quick-xml, I decided to split it for several files, which should enable parallelization of build and speedup itenum_::adjacently_taggedtests #630) added new tests, the results of which will be changed by the fix