Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Fix labeler bot #18674

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

jameerpathan111
Copy link
Contributor

sync-labels: false (which is false by default) is not working. There is an open PR on actions/labeler to fix this issue.
@vcaputo @poettering This should fix issue #18671 for now.

@vcaputo
Copy link
Member

vcaputo commented Feb 18, 2021

Let's give it a try, thanks for following up on this and creating a fix!

@yuwata
Copy link
Member

yuwata commented Feb 18, 2021

So, is this a workaround? And if the PR actions/labeler#113 is merged, then sync-labels: false works as expected?

If so, I think we should wait for the the PR is merged, and then set false instead of "".

@vcaputo
Copy link
Member

vcaputo commented Feb 18, 2021

Hmm, the commit message could use some improvement too.. I defer to @yuwata on where to take this.

@jameerpathan111
Copy link
Contributor Author

So, is this a workaround? And if the PR actions/labeler#113 is merged, then sync-labels: false works as expected?

yes

@bluca
Copy link
Member

bluca commented Feb 18, 2021

So, is this a workaround? And if the PR actions/labeler#113 is merged, then sync-labels: false works as expected?

If so, I think we should wait for the the PR is merged, and then set false instead of "".

That PR has been there unreviewed since November, so I'd much rather we merge this now and fix the improper bot behaviour. I'll subscribe to the other PR and send a revert once it's merged and available. WDYT?

@yuwata
Copy link
Member

yuwata commented Feb 18, 2021

So, is this a workaround? And if the PR actions/labeler#113 is merged, then sync-labels: false works as expected?
If so, I think we should wait for the the PR is merged, and then set false instead of "".

That PR has been there unreviewed since November, so I'd much rather we merge this now and fix the improper bot behaviour. I'll subscribe to the other PR and send a revert once it's merged and available. WDYT?

OK. I agree.

@jameerpathan111 Could you add a comment in the yml file this is a workaround, and also update the commit message?

@jameerpathan111
Copy link
Contributor Author

@jameerpathan111 Could you add a comment in the yml file this is a workaround, and also update the commit message?

@yuwata added comment in yml and updated commit message as well.

@jameerpathan111 jameerpathan111 changed the title Fixes #18671 - github actions bot labeler malfunctioning GH Actions: Fix labeler bot Feb 19, 2021
@yuwata
Copy link
Member

yuwata commented Feb 19, 2021

Thank you!

@yuwata yuwata merged commit 63f48ab into systemd:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants