Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css: Make background a theme-aware property #2056

Merged
merged 1 commit into from
Jan 3, 2022
Merged

css: Make background a theme-aware property #2056

merged 1 commit into from
Jan 3, 2022
+2 −1

Conversation

lachlanjc
Copy link
Member

@lachlanjc lachlanjc commented Dec 30, 2021 •
edited by hasparus
Loading

Closes #2021 (perhaps fittingly!).

📦 Published PR as canary version: 0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0

✨ Test out this PR locally via:

npm install @theme-ui/color-modes@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/color@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/components@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/core@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/css@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/custom-properties@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/editor@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install gatsby-plugin-theme-ui@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install gatsby-theme-style-guide@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install gatsby-theme-ui-layout@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/match-media@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/mdx@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/parse-props@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-base@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-bootstrap@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-bulma@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-dark@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-deep@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-funk@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-future@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-polaris@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-roboto@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-sketchy@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-swiss@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-system@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-tailwind@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/preset-tosh@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/presets@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/prism@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/sidenav@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/style-guide@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/tailwind@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/theme-provider@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install theme-ui@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
npm install @theme-ui/typography@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
# or 
yarn add @theme-ui/color-modes@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/color@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/components@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/core@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/css@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/custom-properties@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/editor@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add gatsby-plugin-theme-ui@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add gatsby-theme-style-guide@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add gatsby-theme-ui-layout@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/match-media@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/mdx@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/parse-props@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-base@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-bootstrap@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-bulma@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-dark@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-deep@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-funk@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-future@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-polaris@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-roboto@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-sketchy@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-swiss@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-system@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-tailwind@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/preset-tosh@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/presets@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/prism@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/sidenav@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/style-guide@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/tailwind@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/theme-provider@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add theme-ui@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0
yarn add @theme-ui/typography@0.13.1--canary.2056.3f06cb0b4ac9d2451cdbf616ad2cce65dbfd95bd.0

Version

Published prerelease version: v0.13.1-develop.7

Changelog

🐛 Bug Fix

  • fix(e2e): downgrade Cypress to 9.0.0 (@hasparus)
  • @theme-ui/css

Authors: 3

@lachlanjc
css: Make background a theme-aware property

Verified

This commit was signed with the committer’s verified signature.
maaaathis mathis
SSH Key Fingerprint: D3h9ZLEwBiGIEsht1I4TEkg2k1VXMHL+mqhn9A4GWwc
Verified
Learn about vigilant mode
b35cbed
@lachlanjc lachlanjc requested a review from hasparus as a code owner December 30, 2021 05:35
@vercel
Copy link

vercel bot commented Dec 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/AVpKYmzvRTB4MT3T1rTakWrWdwrn
✅ Preview: https://theme-ui-git-lachlanjc-css-background-systemui.vercel.app

@hasparus hasparus added the patch Increment the patch version when merged label Jan 3, 2022
@hasparus hasparus merged commit 4434984 into develop Jan 3, 2022
@hasparus hasparus deleted the lachlanjc-css-background branch January 3, 2022 17:30
@hasparus hasparus added the prerelease This change is available in a prerelease. label Jan 3, 2022
This was referenced Jan 4, 2022
Merged
Merged
Merged
@hasparus
Copy link
Member

hasparus commented Jan 5, 2022

🚀 PR was released in v0.13.1 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Jan 5, 2022
@lachlanjc
Copy link
Member Author

How can I make future PRs not show up as "Bug Fix" in the release notes?

@hasparus
Copy link
Member

hasparus commented Jan 5, 2022

How can I make future PRs not show up as "Bug Fix" in the release notes?

You can either prefix your commit with feat(scope): or, I think, possibly add enhancement label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasparus hasparus

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css: Make background a theme-aware property
2 participants
@lachlanjc @hasparus