fix(preset-sketchy): fix emitted types #1924
Merged
+956
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/GNvqNtQK6wKpUhRnnYwtjNKDi5ZC |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1920.
Turns out that a fast build system has its trade-offs. We managed to emit "... 157 more ..." in
preset-sketchytypings due to a object spread in wrong place.I've added a simple test script to ensure it doesn't happen again.
cc @beerose, you might be interested in this one.
📦 Published PR as canary version:
0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0✨ Test out this PR locally via:
npm install @theme-ui/color-modes@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/color@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/components@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/core@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/css@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/custom-properties@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/editor@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install gatsby-plugin-theme-ui@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install gatsby-theme-style-guide@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install gatsby-theme-ui-layout@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/match-media@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/mdx@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/parse-props@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-base@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-bootstrap@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-bulma@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-dark@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-deep@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-funk@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-future@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-polaris@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-roboto@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-sketchy@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-swiss@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-system@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-tailwind@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/preset-tosh@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/presets@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/prism@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/sidenav@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/style-guide@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/tachyons@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/tailwind@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/theme-provider@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install theme-ui@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 npm install @theme-ui/typography@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 # or yarn add @theme-ui/color-modes@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/color@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/components@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/core@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/css@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/custom-properties@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/editor@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add gatsby-plugin-theme-ui@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add gatsby-theme-style-guide@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add gatsby-theme-ui-layout@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/match-media@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/mdx@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/parse-props@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-base@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-bootstrap@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-bulma@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-dark@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-deep@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-funk@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-future@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-polaris@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-roboto@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-sketchy@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-swiss@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-system@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-tailwind@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/preset-tosh@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/presets@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/prism@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/sidenav@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/style-guide@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/tachyons@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/tailwind@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/theme-provider@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add theme-ui@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0 yarn add @theme-ui/typography@0.11.2--canary.1924.32cb414fb0980a12e51f78e3ec823f5536047e35.0