-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Add custom content for sketchy preset demo #1236
feat(docs): Add custom content for sketchy preset demo #1236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of one size fits all solutions like we have right now, I think we should allow presets to affect how their docs are displayed. We already have one size fits all right now. I had mentioned a few ideas in the issue you linked.
|
@hasparus thanks for the feedback, a few changes:
example with borders variants: https://theme-ui-draft.netlify.app/presets/sketchy |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/AYuaxEn3bmGDR58un5znWb5Z4ee1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasparus Any issue with merging this as-is? I think it’s providing a better experience for the sketchy docs than we currently are: Before: https://theme-ui.com/demo |
@hasparus ping on opinions here? |
🚀 PR was released in |
issue #1128
sites:
before: https://theme-ui.com/presets/sketchy
now: https://theme-ui-draft.netlify.app/presets/sketchy