-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin sphinx<7.2.0 to avoid doc build failure. #25542
Conversation
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[8059df73] [f0605682]
<sympy-1.12^0>
- 85.6±2ms 55.4±0.5ms 0.65 integrate.TimeIntegrationRisch02.time_doit(10)
- 83.4±0.4ms 54.6±0.6ms 0.65 integrate.TimeIntegrationRisch02.time_doit_risch(10)
- 6.90±0.01ms 3.66±0ms 0.53 logic.LogicSuite.time_load_file
- 2.11±0.01ms 620±1μs 0.29 polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse')
- 10.4±0.04ms 1.86±0.01ms 0.18 polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse')
- 364±1μs 77.9±0.3μs 0.21 polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse')
- 4.71±0.01ms 343±1μs 0.07 polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse')
- 10.6±0.02ms 1.04±0.01ms 0.10 polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse')
- 6.26±0.01ms 3.80±0.01ms 0.61 polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse')
- 27.5±0.04ms 11.5±0.02ms 0.42 polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse')
- 6.72±0.01ms 1.11±0ms 0.17 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse')
- 15.8±0.06ms 8.91±0.02ms 0.56 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse')
- 205±0.2ms 67.9±0.06ms 0.33 polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse')
- 6.35±0.01ms 504±1μs 0.08 polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse')
- 27.2±0.05ms 801±1μs 0.03 polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse')
- 594±1μs 200±0.8μs 0.34 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse')
- 6.34±0.03ms 205±0.8μs 0.03 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse')
- 16.5±0.06ms 207±1μs 0.01 polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse')
- 162±0.9μs 91.3±0.3μs 0.56 solve.TimeMatrixOperations.time_rref(3, 0)
- 304±0.2μs 108±1μs 0.36 solve.TimeMatrixOperations.time_rref(4, 0)
- 29.8±0.08ms 12.8±0.05ms 0.43 solve.TimeSolveLinSys189x49.time_solve_lin_sys
Full benchmark results can be found as artifacts in GitHub Actions |
doc/src/explanation/gotchas.rst
Outdated
@@ -806,4 +806,4 @@ These will give you the function parameters and docstring for | |||
|
|||
.. module:: sympy.simplify.simplify | |||
.. autofunction:: powsimp | |||
:noindex: | |||
:no-index: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this possible it will fail on Sphinx < 7.2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have just confirmed that locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed that commit
d81fb68
to
0bba59e
Compare
Set to automerge. I'll open a followup PR to unpin the version. |
References to other Issues or PRs
Temporarily fixes #25541
Brief description of what is fixed or changed
Sphinx 7.2.0 came out today and our documentation build (
make html
) fails with this version. This fix should let CI pass until we get it working with version 7.2.0.Other comments
Release Notes
NO ENTRY