Furo docs theme with styling #23159

asmeurer · 2022-02-24T09:40:14Z

References to other Issues or PRs

This is based off of #22864, but I've updated the styling of the Furo theme. This is not at all finished yet, and we also haven't formally decided to switch to Furo yet either.

Demo site here: https://www.asmeurer.com/sympy-furo-demo/

Brief description of what is fixed or changed

I've done a lot of styling, but there are still things that can be improved. Please build the docs and play around with it. If you find something that is low contrast or the wrong color, it probably means it is something I didn't notice.

Also please try both the light and dark theme (you can click the icon at the top of the page).

I haven't changed any fonts or font sizes, except for the code examples. It's a possibility to do this, but I'd like feedback.

CC @bertiewooster

Other comments

TODOs

Check if fonts should be adjusted (different fonts, sizes, etc.)
Add a version selector to the sidebar
Adjust the logo size on mobile (or alternately, make the whole sidebar scrollable)
Fix all remaining contrast issues
Remove all text referencing SymPy Live

Release Notes

other
- The documentation now uses the Furo Sphinx theme.

sympy-bot · 2022-02-24T09:40:23Z

✅

Hi, I am the SymPy bot (v163). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

other
- The documentation now uses the Furo Sphinx theme. (#23159 by @asmeurer and @bertiewooster)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

This is based off of https://github.com/sympy/sympy/pull/22864, but I've updated the styling of the Furo theme. This is not at all finished yet, and we also haven't formally decided to switch to Furo yet either. 

Demo site here: https://www.asmeurer.com/sympy-furo-demo/


#### Brief description of what is fixed or changed

I've done a lot of styling, but there are still things that can be improved. Please build the docs and play around with it. If you find something that is low contrast or the wrong color, it probably means it is something I didn't notice.

Also please try both the light and dark theme (you can click the icon at the top of the page).

I haven't changed any fonts or font sizes, except for the code examples. It's a possibility to do this, but I'd like feedback. 

CC @bertiewooster 

#### Other comments

**TODOs**

- [x] Check if fonts should be adjusted (different fonts, sizes, etc.)
- [x] Add a version selector to the sidebar
- [x] Adjust the logo size on mobile (or alternately, make the whole sidebar scrollable)
- [x] Fix all remaining contrast issues
- [x] Remove all text referencing SymPy Live

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- other
  - The documentation now uses the [Furo](https://pradyunsg.me/furo/) Sphinx theme. 
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

sympy-bot · 2022-02-24T09:40:26Z

🟠

Hi, I am the SymPy bot (v163). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits add new files:

bbe3269:
- doc/src/_static/custom.css
90ff6b1:
- doc/src/_templates/sidebar/versions.html
abf5039:
- doc/src/_pygments/styles.py

The following commits delete files:

4b00be3:
- doc/ext/sympylive.py
f5ae2cf:
- doc/src/_static/default.css_t
c233492:
- doc/src/_templates/layout.html

If these files were added/deleted on purpose, you can ignore this message.

github-actions · 2022-02-24T11:06:40Z

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [459a2aa4]
     <sympy-1.10.1^0>                 
+      98.7±0.6ms        178±0.8ms     1.80  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

asmeurer · 2022-02-24T20:17:03Z

Note: we should probably rebase away the submodule addition before merging any of this.

asmeurer · 2022-02-24T20:23:30Z

I've uploaded a demo site so you don't have to build this yourself https://github.com/asmeurer/sympy-furo-demo

bertiewooster · 2022-02-24T22:25:26Z

Thanks @asmeurer. To save folks a click, the built site is at https://www.asmeurer.com/sympy-furo-demo/

bertiewooster · 2022-02-25T00:11:44Z

Great start! Comments:

The Search box appears to connect to the body of the page, because they're about the same color. The Furo example site has the search box the same color as the rest of the left navbar. Is that possible and advisable? I can imagine that having a dark green background would make it hard to read black text being input; is it possible to make the input text a light color?
Lighthouse reports that the accessibility is very good, at 98/100. The one problem it found is Background and foreground colors do not have a sufficient contrast ratio.
1. One situation where this occurs is the light green text in a function template light gray box, for example sympy.core.sympify.. It also occurs for links (for example, "next section"), which are light green on white background. Perhaps make those types of text dark green instead of light? Personally, I prefer lighter colors for large page elements, so maybe make the left navbar a light green, and the text in the function template a dark green?
2. Another is the text in a code block. Perhaps make the code block background color lighter?

asmeurer · 2022-02-25T01:01:34Z

The Search box appears to connect to the body of the page, because they're about the same color. The Furo example site has the search box the same color as the rest of the left navbar. Is that possible and advisable? I can imagine that having a dark green background would make it hard to read black text being input; is it possible to make the input text a light color?

Sure that's doable. I'm not sure how good it would look. Having it blend in does make it harder to see. I guess the flip side of that is that it's less distracting. The current docs site has the search bar white https://docs.sympy.org/dev/index.html.

Lighthouse reports that the accessibility is very good, at 98/100. The one problem it found is Background and foreground colors do not have a sufficient contrast ratio.

Yeah, I noticed some of these things as well (the Chrome inspect accessibility thing flagged them).

I'm a little unsure how to fix some of them. A problem I noticed with these color contrast checkers is that they only consider the contrast of the text against its background. They don't consider the contrast of the text with the surrounding text. This is particularly important for the link color. We can make the (currently green) links have a better contrast against the background by making them darker, but then they become harder to see as links against the surrounding black text (you can see what I mean if you right click "inspect" a link in Chrome and then click the color in the inspector and choose the suggested higher contrast color).

I can try flipping the dark and light greens to see how it looks.

I was also planning on adjusting the code block background (which should be easier than trying to restyle all the different syntax highlighting colors). The problem is the Chrome dev tools only support suggesting foreground colors, not background colors. But I did find https://accessible-colors.com/ which allows both. AAA is hard to achieve while still keeping distinguishable colors, but we should be able to get AA I think. I also tried just messing with the color picker, but I had a hard time finding something I liked aesthetically. I do personally like how the code blocks stand out as I think the examples are the most important part of documentation.

pradyunsg · 2022-02-25T06:00:35Z

doc/src/conf.py

+
+html_theme_options = {
+    "light_css_variables": css_settings_common,
+    "dark_css_variables": {**css_settings_common,


You shouldn't need this -- the light mode variables get inherited for dark mode.

See https://pradyunsg.me/furo/customisation/colors/#how-light-and-dark-mode-work for the relevant details.

I didn't realize this. It would be nice if this were mentioned at https://pradyunsg.me/furo/customisation/#light-css-variables-dark-css-variables

This was working, but I updated to the latest Furo and it stopped working and I had to separate them again.

pradyunsg · 2022-02-25T06:08:30Z

Add a version selector to the sidebar

Relevant here: https://pradyunsg.me/furo/customisation/sidebar/. See also pradyunsg/furo#372.

moorepants · 2022-02-25T10:08:37Z

This is looking pretty nice. I like the green!
I noticed that the API rendering isn't so great:

The name of the function/class/method doesn't stand out. The bold "parent" "axisreturns" etc overwhelms the name of the function. The name of the functions should be the most distinct thing on the page. The boldness of the heads "parameters", "warns" is not even present. Also the notes are way too strong (in color I guess):

This also detracts from the function name which should be the most prominent thing.

moorepants · 2022-02-25T10:09:13Z

If you scroll through the api listing, the function names should be the only thing you can detect while scrolling (or the primary thing).

namannimmo10 · 2022-02-25T21:18:26Z

Thanks for this. The new docs site looks really nice!

asmeurer · 2022-03-03T23:34:02Z

Addressed some comments and additional things I noticed:

Removed the fancy scrolling when jumping to an anchor (it was too slow on long pages)
Made the API headings easier to see. They are also now the only part of the page that is colored.
"See also" and "Notes" now use a gray background instead of green. "Warning" is still red.
Removed the extra vertical space in the parameters section.
Made the "Parameters", "Returns", "Examples", and so on more prominent.
Added a GitHub icon to the footer.
Made the code block background color slightly dimmer to improve the color contrast.
Various small fixes to improve color contrast, especially in dark mode.

I had one idea also, which is to make the function names easier to "spot" on the page by inverting the colors to make the background green (it is currently grey), and the text black (or some other color that's easy to read on green). I'm a little unsure about it, though. Let me know if you think it would be better that way or the way it is now.

asmeurer · 2022-03-03T23:47:32Z

Another note: we are doing enough modifications in custom.css that it might be a good idea to pin the Furo version. We can update it every once in a while, but whenever we do, we have to check if any CSS modifications are required. Even without custom.css, after updating my local version Furo, there were some additional "supported" CSS variables added that required updating.

asmeurer · 2022-03-04T00:21:25Z

I had one idea also, which is to make the function names easier to "spot" on the page by inverting the colors to make the background green (it is currently grey), and the text black (or some other color that's easy to read on green). I'm a little unsure about it, though. Let me know if you think it would be better that way or the way it is now.

Here's a quick mockup of what I mean. Right now, it looks like this:

I'm wondering if we should instead change it to something like this:

Or would that be too noisy on the page? It would only apply to function and class definitions in the API docs, not other headers.

bertiewooster · 2022-03-04T00:48:32Z

Thanks for doing all this detailed work, @asmeurer. I do find the second version visually noisy, as I prefer blocks of color to be subtle; that also makes it easier to achieve sufficient color contrast. How about largely keeping the first version, and making the module prefix names text the darker green? The actual function name could be bold to distinguish it from the module prefixes.

asmeurer · 2022-03-04T02:15:07Z

Pushed a few more fixes:

The logo is now high resolution.
Various contrast fixes for dark mode, especially in the syntax highlighting.

I'm honestly still not sure how to handle the lighthouse contrast issues in light mode. Unlike dark mode, most of the suggestions for contrast improvements in light mode seem to make the text too close to black to be distinguishable.

Is there an easy way to run lighthouse on every page, with both light and dark mode? I've been running it one page at a time, but different pages have different elements. There are way too many pages to run each page manually.

moorepants · 2022-03-04T05:58:41Z

I like both, definitely fixes the issues I reaised. Thanks! For the second, the green bars are strong. Maybe a lighter shade of green would be better. The first one is good too though, and sufficient.

bertiewooster · 2022-03-04T13:48:27Z

Is there an easy way to run lighthouse on every page, with both light and dark mode?

Lighthouse can be run via npm; I haven't tried that.

I'm not sure if there's a way to automatically do that in both light and dark mode, as the URL doesn't change when I click dark mode. The mode selection does persist when you go from one page to another, so perhaps you could run the Lighthouse scans in light mode, then change to dark mode, then re-running the Lighthouse scans might use the dark mode? I'm not sure if that mode will be picked up by the npm version of Lighthouse.

asmeurer · 2022-03-04T21:32:59Z

It looks like you can force dark mode with the --chrome-flags. But I don't see an easy way to use this to scan every page. It would be nice if there were a tool that just scanned the local HTML files.

asmeurer · 2022-03-05T01:31:11Z

Another thing we can do with Furo is to add a header to each page in the development docs like this:

Not sure if it's actually a good idea, though. And I would need to figure out how to make it cross-link with Javascript since it doesn't seem to be Jinja templated.

bertiewooster · 2022-03-05T02:03:39Z

Another thing we can do with Furo is to add a header to each page in the development docs like this:

I was thinking it'd be nice to temporarily add headers to each page (in both released and dev docs) when we want to publicize a survey or the like to the community--that would reach anyone who uses the docs, not just people who follow SymPy on Github, Twitter, Gitter, etc. Is there an easy way to do that?

bertiewooster · 2022-03-05T02:06:45Z

I don't see an easy way to use this to scan every page. It would be nice if there were a tool that just scanned the local HTML files.

I think Lighthouse only works if the page is posted on a server. I wonder if there's a way to give it a sitemap to have it visit all the mapped pages?

asmeurer · 2022-03-05T02:06:51Z

The announcement feature makes it quite easy to add it to the dev docs. To add it to the "latest" docs we would need to manually rebuild the docs from that git tag with the given header (which isn't too hard).

asmeurer · 2022-03-22T00:38:01Z

Some updates

The current page is now highlighted in the sidebar. For example:
I've made it so that the whole sidebar scrolls. Previously the logo would be pinned to the top of the page and only the table of contents would scroll. This should make the sidebar more usable on mobile, where the logo takes up a large amount of vertical space.
I've added a version selection menu to the sidebar. You can see what it looks like at the bottom of the sidebar at https://www.asmeurer.com/sympy-furo-demo/dev/index.html.

This uses a file called versions.json which will be placed at the root of the sympy_doc repo, which looks like
```
{
    "latest": "1.10",
    "dev": "1.11.dev"
}
```
If you build the docs locally the file won't be present and the docs will look like this

This is much simpler than the current solution which injects code into the page after it is built. It also has the advantage that the version selector now appears on every page, not just the index page. Some new code will need to be added to the release process to update the versions.json file.
I have removed all references to the SymPy Live extension (mostly from the tutorial). If we ever add a replacement that uses pyiodide, we can reintroduce this text. For now, the extension has been removed because it is not compatible with the Furo theme, and has other issues as well.

This is now ready for review. I have made all the style changes I wanted to make, so please let me know if you see anything that you feel should be changed in any way. Also if anyone is knowledgeable about CSS or Javascript I would appreciate a review of my CSS in custom.css and Javascript in versions.html, as I'm not great at either language.

pradyunsg · 2022-04-01T08:35:49Z

doc/src/_static/custom.css

+/* Make the "class", "property" and so on before function names in the API*/
+/* docs bold. */
+em.property:first-child {
+    font-weight: bold;
+}


The entire signature is bold by default, so you shouldn't need this.

Looks like you are right. This must have been left over from a previous iteration.

pradyunsg · 2022-04-01T08:37:15Z

doc/src/_templates/sidebar/versions.html

+}
+-->
+<div class="sidebar-tree sidebar-versions">
+  <h5 class="versions-header">Documentation Version</h4>


I would suggest adding a padding-left to this, to align it with the rest of the sidebar content. You might want to consider if you want this to look like sidebar captions instead of a heading.

I'll have to play with it some more. I'm OK with the way it currently looks but I'll see if it looks better this way. Note that I'm not a designer and my HTML/Javascript/CSS skills are terrible, so if you see something that looks off, it's most likely unintentional so please let me know.

Actually this was supposed to have the exact same padding as the rest of the sidebar, but my editor inserted an incorrect line break in the CSS and messed it up. Should look better now.

pradyunsg · 2022-04-01T08:37:46Z

doc/src/conf.py

+    "light_css_variables": common_theme_variables,
+    # The dark variables automatically inherit values from the light variables
+    "dark_css_variables": {
+        **common_theme_variables,


You likely do not need this.

If I comment this line out, the light specific modifications do not carry over to dark mode. I think it was working before when I had an older version of Furo but it stopped working when I updated it.

Hmm... Fascinating. I'll dig into what's happening here later. I'm pretty sure this won't do the wrong thing though, so this is definitely fine to do anyway. :)

pradyunsg · 2022-04-01T08:39:25Z

doc/src/conf.py

@@ -220,6 +308,7 @@
 # SymPy logo on title page
 html_logo = '_static/sympylogo.png'
 latex_logo = '_static/sympylogo_big.png'
+html_favicon = '../_build/logo/sympy-notailtext-favicon.ico'


This should likely be logo/... instead? Otherwise, you won't get the logo on the first build (unless I'm misunderstanding your build process).

Yeah, we compile the logo from svg to png and ico as part of the build process (the Makefile dependencies ensure it's compiled first).

pradyunsg · 2022-04-01T08:46:42Z

We might want to try upstreaming these changes, although I'm unsure if pygments or sphinx would accept color changes to their themes or if they would consider that to be backwards incompatible. @pradyunsg you may also be interested in this if you want Furo to have better WCAG compatibility.

If pygments gets new better-contrast themes or improves their themes, I'd be very happy to see that. I had considered writing custom pygments theme that had a better contrast story, but I decided against that to minimise how much stuff I was doing in the theme; to instead try contributing to those projects instead.

I haven't actually had the time/mental space to come around to doing that though, so I welcome this! :)

asmeurer · 2022-04-01T22:30:12Z

Thanks for the review @pradyunsg.

You likely want to override --color-sidebar-background-border as well.

Wow that's a very subtle thing, especially with my other overrides. I guess the best thing to set this to when the sidebar has a different background color as in our case is to var(--color-background-primary).

You can use {% block announcement %} in page.html, to provide the internal content of the announcement, if that's what you want -- as long as you set announcement in html_theme_options to a truthy value.

I don't think we have any announcements we want to add at this point, but that's good to know for the future. We could consider adding one for the dev pages, but I still unsure if it's a good idea.

If pygments gets new better-contrast themes or improves their themes, I'd be very happy to see that. I had considered writing custom pygments theme that had a better contrast story, but I decided against that to minimise how much stuff I was doing in the theme; to instead try contributing to those projects instead.

I more or less feel the same way. I didn't want to spend a whole lot of time on this, as I know it could end up being a huge rabbit hole that would ultimately produce a lot of good work, but not end up being related to the SymPy documentation. That's why I came up with a pretty hacky solution that just reuses the Ruby script I found at https://github.com/mpchadwick/pygments-high-contrast-stylesheets/blob/gh-pages/tools/make-stylesheet. It gets the job done for us, and makes the SymPy docs WCAG compatible.

Ideally the whole thing would be done in Python (I'm not sure what the best library for that would be), and and be more convenient to use. For instance, one could have a function that just takes a pygments theme and automatically makes it WCAG AA compatible without requiring any manual work. Or alternately, just change the themes upstream to be AA compatible. But given that pygments specifically notates which styles have bad contrast gives me the impression that simply updating them is not a simple thing for them to do. The "sphinx" style is actually part of Sphinx, so updating that would be a separate discussion (but again, likely not a simple proposition, as it would affect a lot of projects, including docs.python.org itself).

So for now I'm going to leave this as an open project for someone else to implement, but if you or anyone else ever does, please let me know.

bertiewooster · 2022-04-03T18:51:54Z

The Lighthouse report reveals an accessibility contrast issue with class etc. green names against a gray background, whether the green text is regular or bold:

That situation seems to be the only contrast issue; the code blocks are fine.

It's only used in two places, the left sidebar hover, and the right sidebar active page. This color was taken from the SymPy logo, and modified slightly to have a 4.5 contrast ratio. Unlike the previous color, this one now has good contrast, except in dark mode, where we use the old color for the black background.

- Use color-brand-content and color-brand-primary instead of redefining specific things. - Remove the gray selected header color. It creates bad color contrast. The default yellow is easier to work with. - The primary and content colors now have at least 4.5 contrast, including when the header is selected. - Remove some colors that were defined to nearly identical colors as the defaults (but which still have fine color contrast).

Apparently it actually is needed for color contrast compared to the default.

asmeurer · 2022-04-06T08:24:07Z

I fixed that and cleaned up some of the colors a bit (we now just have the two greens in color-brand-content and color-brand-primary). Also fixed some contrast issues that only showed when selecting a header (lighthouse does not see these unless you give a URL with an anchor). I also changed the hover color in the left sidebar because it had bad contrast (lighthouse does not look at hover colors).

bertiewooster · 2022-04-07T00:40:00Z

Great, thanks for going beyond even the automated Lighthouse checks to ensure that as many people as possible can use SymPy documentation.

Comparing the current version (above) to the restyled version (below) demonstrates how much cleaner, more navigable, and more functional the restyled site will be:

.

asmeurer · 2022-04-07T01:01:02Z

If there are no further comments, I'd like to merge this. If we find something later that I've missed, we can make additional PRs to fix. It will be good to have this in the dev docs soon so that we can find any such issues before it gets released to the main "latest" documentation.

Let's open new issues for the items we discussed above that were not addressed in this PR.

oscarbenjamin · 2022-04-07T09:44:06Z

Looks good to me. Let's get this in.

asmeurer · 2022-04-07T17:06:55Z

Looks like I forgot to update the dependencies for Travis. Fix forthcoming.

asmeurer · 2022-04-07T19:30:10Z

I opened several issues for things that were discussed here but not addressed (see the cross references above this comment). If I missed anything, please open an issue for it.

This removes the separate colors for visited and unvisited. We now use the darker of the two in light mode and the ligher of the two in dark mode. These colors satisfy AA color contrast, both against the background and against the surrounding black/white text (see sympy#23159). This replaces the "brand-content" color in light mode since this is primarily used for links. We still use the lighter color for the API function names in light mode, so that they pop out more (dark mode already has a lighter color for API function names).

pradyunsg reviewed Feb 25, 2022

View reviewed changes

oscarbenjamin added the Documentation label Feb 26, 2022

asmeurer closed this Mar 5, 2022

asmeurer reopened this Mar 5, 2022

asmeurer marked this pull request as ready for review March 22, 2022 00:38

pradyunsg reviewed Apr 1, 2022

View reviewed changes

asmeurer added 7 commits April 5, 2022 16:50

Remove an unnecessary piece of CSS

3439213

Fix the sidebar border color

75c8be0

Make the API function names have better color contrast

cb2182c

Reapply the color-foreground-secondary for dark mode

3ecf36c

Apparently it actually is needed for color contrast compared to the default.

Fix the sidebar hover colors in dark mode

d7a3723

Fix incorrect line wrapping in the CSS

8bc4a04

oscarbenjamin added the CZI: Documentation Issues and pull requests relating to Aaron Meurer's CZI grant documentation project label Apr 7, 2022

oscarbenjamin merged commit 19ed9ef into sympy:master Apr 7, 2022

This was referenced Apr 7, 2022

Use sphinx-opengraph in the documentation #23331

Open

Improve documentation formatting by changing Sphinx theme #22716

Closed

Use one header per function on the API docs pages #23332

Closed

Clean up some of the layout in the docs #23333

Open

asmeurer mentioned this pull request Apr 8, 2022

Use JupyterLite for the interactive REPL sympy/sympy-live#198

Closed

3 tasks

asmeurer mentioned this pull request May 15, 2024

Visited links are colored purple in the docs #26599

Open

Furo docs theme with styling #23159

Furo docs theme with styling #23159

Conversation

asmeurer commented Feb 24, 2022 • edited

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

sympy-bot commented Feb 24, 2022 • edited

sympy-bot commented Feb 24, 2022 • edited

🟠

github-actions bot commented Feb 24, 2022 • edited

asmeurer commented Feb 24, 2022

asmeurer commented Feb 24, 2022

bertiewooster commented Feb 24, 2022

bertiewooster commented Feb 25, 2022 • edited

asmeurer commented Feb 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pradyunsg commented Feb 25, 2022

moorepants commented Feb 25, 2022 • edited

moorepants commented Feb 25, 2022

namannimmo10 commented Feb 25, 2022

asmeurer commented Mar 3, 2022

asmeurer commented Mar 3, 2022

asmeurer commented Mar 4, 2022

bertiewooster commented Mar 4, 2022

asmeurer commented Mar 4, 2022

moorepants commented Mar 4, 2022

bertiewooster commented Mar 4, 2022

asmeurer commented Mar 4, 2022

asmeurer commented Mar 5, 2022 • edited

bertiewooster commented Mar 5, 2022

bertiewooster commented Mar 5, 2022

asmeurer commented Mar 5, 2022

asmeurer commented Mar 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pradyunsg commented Apr 1, 2022 • edited

asmeurer commented Apr 1, 2022 • edited

bertiewooster commented Apr 3, 2022

asmeurer commented Apr 6, 2022

bertiewooster commented Apr 7, 2022

asmeurer commented Apr 7, 2022

oscarbenjamin commented Apr 7, 2022

asmeurer commented Apr 7, 2022

asmeurer commented Apr 7, 2022

asmeurer commented Feb 24, 2022 •

edited

sympy-bot commented Feb 24, 2022 •

edited

sympy-bot commented Feb 24, 2022 •

edited

github-actions bot commented Feb 24, 2022 •

edited

bertiewooster commented Feb 25, 2022 •

edited

moorepants commented Feb 25, 2022 •

edited

asmeurer commented Mar 5, 2022 •

edited

pradyunsg commented Apr 1, 2022 •

edited

asmeurer commented Apr 1, 2022 •

edited