Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RequireThisCallOnLocalMethodRule, as not practical #53

Merged
merged 1 commit into from May 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion config/static-rules.neon
Expand Up @@ -29,7 +29,6 @@ rules:
# explicit naming
- Symplify\PHPStanRules\Rules\NoDefaultExceptionRule
- Symplify\PHPStanRules\Rules\NoParentMethodCallOnNoOverrideProcessRule
- Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule
- Symplify\PHPStanRules\Rules\ForbiddenMultipleClassLikeInOneFileRule

# comlexity
Expand Down
44 changes: 1 addition & 43 deletions docs/rules_overview.md
@@ -1,4 +1,4 @@
# 87 Rules Overview
# 86 Rules Overview

## AnnotateRegexClassConstWithRegexLinkRule

Expand Down Expand Up @@ -2922,48 +2922,6 @@ final class IssueControl extends Control

<br>

## RequireThisCallOnLocalMethodRule

Use "$this-><method>()" instead of "self::<method>()" to call local method

- class: [`Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule`](../src/Rules/RequireThisCallOnLocalMethodRule.php)

```php
class SomeClass
{
public function run()
{
self::execute();
}

private function execute()
{
}
}
```

:x:

<br>

```php
class SomeClass
{
public function run()
{
$this->execute();
}

private function execute()
{
}
}
```

:+1:

<br>

## RequireUniqueEnumConstantRule

Enum constants "%s" are duplicated. Make them unique instead
Expand Down
133 changes: 0 additions & 133 deletions src/Rules/RequireThisCallOnLocalMethodRule.php

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.