[Mailer] Fix sendmail transport failure handling and interactive mode #54572
+106
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
fix-sendmail
branch
from
e13f7c7
to
3c9a46d
Compare
nicolas-grekas
changed the title
fabpot
reviewed
Apr 17, 2024
src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
May 30, 2024
|
Thank you @bobvandevijver. |
This was referenced May 31, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54239 introduced an issue for us when using sendmail in interactive mode using a long running background worker. It will throw exceptions due to an unclean shutdown in case of an SMTP timeout (5 minute by default), while in interactive mode all output is actually handled by the SMTP transport, including that timeout. That makes the exit code of the long running process not relevant in that mode. See the bug report for some more details.
I have verified that this change solves my production issues, although I am not particularly fond on the hoops I had to jump to show this in the test.
cc @aboks