[Console] Only execute additional checks for color support if the output is a TTY #53576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
fix/color-detection-tty
branch
from
a75879b
to
e013317
Compare
theofidry
commented
Jan 18, 2024
fabpot
requested changes
Jan 19, 2024
theofidry
force-pushed
the
fix/color-detection-tty
branch
from
e013317
to
2e96b22
Compare
xabbuh
approved these changes
Jan 19, 2024
fabpot
approved these changes
Jan 19, 2024
|
Thank you @theofidry. |
chalasr
changed the title
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Feb 3, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix color support for TTY output | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #53693 | License | MIT Prior to #53576, the output being a TTY was sufficient to consider the output as supporting colors. This is not enough but as a result, we are missing some additional checks. This PR: - Adds a check for the `COLORTERM` environment variable. From what I've found it does not look this variable is ever set if there is no color support. - Adds a check for the `screen-*` `TERM` values. Similar to the check we already for `xterm`, you have `screen-256color`, `screen-256color-bce`, `screen.xterm-256color` or more. Commits ------- 22efcd0 [Console] Fix color support
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Feb 3, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix color support for TTY output | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #53693 | License | MIT Prior to symfony/symfony#53576, the output being a TTY was sufficient to consider the output as supporting colors. This is not enough but as a result, we are missing some additional checks. This PR: - Adds a check for the `COLORTERM` environment variable. From what I've found it does not look this variable is ever set if there is no color support. - Adds a check for the `screen-*` `TERM` values. Similar to the check we already for `xterm`, you have `screen-256color`, `screen-256color-bce`, `screen.xterm-256color` or more. Commits ------- 22efcd028b [Console] Fix color support
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Feb 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/console](https://symfony.com) ([source](https://togithub.com/symfony/console)) | `6.4.2` -> `6.4.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/process](https://symfony.com) ([source](https://togithub.com/symfony/process)) | `6.4.2` -> `6.4.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/console (symfony/console)</summary> ### [`v6.4.3`](https://togithub.com/symfony/console/releases/tag/v6.4.3) [Compare Source](https://togithub.com/symfony/console/compare/v6.4.2...v6.4.3) **Changelog** (symfony/console@v6.4.2...v6.4.3) - bug [symfony/symfony#53516](https://togithub.com/symfony/symfony/issues/53516) \[Console] Allow '0' as a $shortcut in InputOption.php ([@​lawsonjl-ornl](https://togithub.com/lawsonjl-ornl)) - bug [symfony/symfony#53576](https://togithub.com/symfony/symfony/issues/53576) \[Console] Only execute additional checks for color support if the output ([@​theofidry](https://togithub.com/theofidry)) </details> <details> <summary>symfony/process (symfony/process)</summary> ### [`v6.4.3`](https://togithub.com/symfony/process/compare/v6.4.2...v6.4.3) [Compare Source](https://togithub.com/symfony/process/compare/v6.4.2...v6.4.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Mar 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [symfony/console](https://symfony.com) ([source](https://togithub.com/symfony/console)) | `6.4.4` -> `7.0.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/process](https://symfony.com) ([source](https://togithub.com/symfony/process)) | `6.4.4` -> `7.0.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>symfony/console (symfony/console)</summary> ### [`v7.0.4`](https://togithub.com/symfony/console/releases/tag/v7.0.4) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.3...v7.0.4) **Changelog** (symfony/console@v7.0.3...v7.0.4) - bug [symfony/symfony#54009](https://togithub.com/symfony/symfony/issues/54009) \[Console] Fix display of vertical Table on Windows OS ([@​VincentLanglet](https://togithub.com/VincentLanglet)) - bug [symfony/symfony#54001](https://togithub.com/symfony/symfony/issues/54001) \[Console] Fix display of Table on Windows OS ([@​VincentLanglet](https://togithub.com/VincentLanglet)) - bug [symfony/symfony#53707](https://togithub.com/symfony/symfony/issues/53707) \[Console] Fix color support for TTY output ([@​theofidry](https://togithub.com/theofidry)) - bug [symfony/symfony#53711](https://togithub.com/symfony/symfony/issues/53711) \[Console] Allow false as a $shortcut in InputOption ([@​jayminsilicon](https://togithub.com/jayminsilicon)) ### [`v7.0.3`](https://togithub.com/symfony/console/releases/tag/v7.0.3) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.2...v7.0.3) **Changelog** (symfony/console@v7.0.2...v7.0.3) - bug [symfony/symfony#53516](https://togithub.com/symfony/symfony/issues/53516) \[Console] Allow '0' as a $shortcut in InputOption.php ([@​lawsonjl-ornl](https://togithub.com/lawsonjl-ornl)) - bug [symfony/symfony#53576](https://togithub.com/symfony/symfony/issues/53576) \[Console] Only execute additional checks for color support if the output ([@​theofidry](https://togithub.com/theofidry)) ### [`v7.0.2`](https://togithub.com/symfony/console/releases/tag/v7.0.2) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.1...v7.0.2) **Changelog** (symfony/console@v7.0.1...v7.0.2) - bug [symfony/symfony#52940](https://togithub.com/symfony/symfony/issues/52940) \[Console] Fix color support check on non-Windows platforms ([@​theofidry](https://togithub.com/theofidry)) - bug [symfony/symfony#52941](https://togithub.com/symfony/symfony/issues/52941) \[Console] Fix xterm detection ([@​theofidry](https://togithub.com/theofidry)) ### [`v7.0.1`](https://togithub.com/symfony/console/releases/tag/v7.0.1) [Compare Source](https://togithub.com/symfony/console/compare/v7.0.0...v7.0.1) **Changelog** (symfony/console@v7.0.0...v7.0.1) - no significant changes ### [`v7.0.0`](https://togithub.com/symfony/console/releases/tag/v7.0.0) [Compare Source](https://togithub.com/symfony/console/compare/v6.4.4...v7.0.0) **Changelog** (symfony/console@v7.0.0-RC2...v7.0.0) - no significant changes </details> <details> <summary>symfony/process (symfony/process)</summary> ### [`v7.0.4`](https://togithub.com/symfony/process/releases/tag/v7.0.4) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.3...v7.0.4) **Changelog** (symfony/process@v7.0.3...v7.0.4) - bug [symfony/symfony#54006](https://togithub.com/symfony/symfony/issues/54006) \[Process] Fix the `command -v` exception (@​kayw-geek) - bug [symfony/symfony#53821](https://togithub.com/symfony/symfony/issues/53821) \[Process] Fix Inconsistent Exit Status in proc_get_status for PHP Versions Below 8.3 ([@​Luc45](https://togithub.com/Luc45)) ### [`v7.0.3`](https://togithub.com/symfony/process/releases/tag/v7.0.3) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.2...v7.0.3) **Changelog** (symfony/process@v7.0.2...v7.0.3) - bug [symfony/symfony#53481](https://togithub.com/symfony/symfony/issues/53481) \[Process] Fix executable finder when the command starts with a dash ([@​kayw-geek](https://togithub.com/kayw-geek)) ### [`v7.0.2`](https://togithub.com/symfony/process/releases/tag/v7.0.2) [Compare Source](https://togithub.com/symfony/process/compare/v7.0.0...v7.0.2) **Changelog** (symfony/process@v7.0.1...v7.0.2) - bug [symfony/symfony#52864](https://togithub.com/symfony/symfony/issues/52864) \[HttpClient]\[Mailer]\[Process] always pass microseconds to usleep as integers ([@​xabbuh](https://togithub.com/xabbuh)) ### [`v7.0.0`](https://togithub.com/symfony/process/releases/tag/v7.0.0) [Compare Source](https://togithub.com/symfony/process/compare/v6.4.4...v7.0.0) **Changelog** (symfony/process@v7.0.0-RC2...v7.0.0) - no significant changes </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #53460, the modifications done in #52940 are incorrect as it results in detecting that the stream can support colors despite not being a TTY.
Rather than doing a simple revert which would re-introduce the pre-existing issue that #52940 attempted to fix, this PR checks if the output is a TTY based on Composer's code and does this check before anything else.
Indeed a TTY only means that colors may be supported, so the various checks that we were doing do make sense to be done but should be done after this TTY (so
Hyperis not an exception, it can be a TTY or not).