Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Fix generated application link #52152

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[WebProfilerBundle] Fix generated application link #52152

merged 1 commit into from
Oct 19, 2023

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

I played a little bit with the new Profiling command #47416 (I love it !), and found that type=command is missing in one URL

image

@carsonbot carsonbot added this to the 6.4 milestone Oct 18, 2023
HeahDude
HeahDude approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch, thanks!

@fabpot
Copy link
Member

fabpot commented Oct 19, 2023

Thank you @alamirault.

@fabpot fabpot merged commit 67ecd29 into symfony:6.4 Oct 19, 2023
6 of 9 checks passed
@alamirault alamirault deleted the hotfix/fix-command-link branch October 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alamirault @fabpot @HeahDude @carsonbot