Revert "Respect isRetryable decision of the retry strategy for re-delivery" #50655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egy when deciding if failed message should be re-delivered" This reverts commit 8fc3dcc.
bendavies
changed the title
nicolas-grekas
changed the title
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Jun 20, 2023
carsonbot
changed the title
|
Thank you @bendavies. |
This was referenced Jun 26, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "[Messenger] Respect
isRetryabledecision of the retry strategy when deciding if failed message should be re-delivered"This reverts #49063
The linked PR rendered
RecoverableExceptionInterfaceuseless - i.e. it would not retry indefinately as stated in the docs.See the discussion on the original PR