Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Tweak the HTML code of the Twig entry view #50325

Merged
merged 1 commit into from
May 16, 2023

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Stretched links are used to make entire sections, like a card, clickable. See https://getbootstrap.com/docs/5.3/helpers/stretched-link/

Maybe @PhilETaylor can answer us about this (he made the original PR to add this in #49887) but I think it wasn't intended to make entire Twig panel clickable to open the template. So, in this PR I propose to remove this behavior.

Here you can see how in the Security panel, the link is not stretched but in the Twig panel it is:

profiler-panel

@PhilETaylor
Copy link
Contributor

I just copied and pasted code from elsewhere in the toolbar, sorry.

I never noticed this problem, but I can confirm it's not meant to be like this and needs fixing, thanks for correcting my bad code.

Since adding this feature though, it's literally been the thing I click most in the toolbar - its a real timesaver.

@javiereguiluz
Copy link
Member Author

Phil, thanks for confirming this. So, then this is OK for review and merge. Thanks.

@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit 5c40d30 into symfony:6.3 May 16, 2023
8 of 9 checks passed
@fabpot fabpot mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants