Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduler] debug:schedule refinements #49807

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 25, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Followup to #49795
License MIT
Doc PR n/a

Some fixes/refinements to the output:

  1. If the message is an envelope, unwrap
  2. prefix stringable message/trigger with short class name
 --------------------------- -------------------------------------- --------------------------- 
  Message                     Trigger                                Next Run                   
 --------------------------- -------------------------------------- --------------------------- 
  DoSomething: do something   CronExpressionTrigger: * * * * *       2023-03-25T08:03:00-04:00  
 --------------------------- -------------------------------------- ---------------------------

@kbond
Copy link
Member Author

kbond commented Mar 25, 2023

Currently, when outputting the message, if it's \Stringable, we use that. This might not be desired...

Do you think there would be value in a DescribableMessageInterface in messenger that provides a getMessageDescription() method? There could be other usages, like using as the context in #49792.

@kbond kbond force-pushed the scheduler-debug-refinements branch from 4096b5e to 8a399ed Compare March 27, 2023 14:06
@kbond
Copy link
Member Author

kbond commented Mar 27, 2023

Do you think there would be value in a DescribableMessageInterface in messenger that provides a getMessageDescription() method? There could be other usages, like using as the context in #49792.

Another, perhaps more palatable idea: #49792 (comment)

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep using the toString() method for the message. For the trigger, we might decide that TriggerInterface extends Stringable.

@fabpot
Copy link
Member

fabpot commented Mar 29, 2023

Thank you @kbond.

@fabpot fabpot force-pushed the scheduler-debug-refinements branch from 8a399ed to 8396210 Compare March 29, 2023 18:29
@fabpot fabpot merged commit 2be7e2d into symfony:6.3 Mar 29, 2023
@kbond kbond deleted the scheduler-debug-refinements branch March 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants