[Scheduler] randomize a cron schedule #49806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsykun
force-pushed
the
feature/add-random-delay
branch
from
59df6f9
to
d06e0ff
Compare
welcoMattic
reviewed
Mar 25, 2023
vtsykun
force-pushed
the
feature/add-random-delay
branch
from
d06e0ff
to
2bb84c2
Compare
… amount of seconds
vtsykun
force-pushed
the
feature/add-random-delay
branch
from
2bb84c2
to
9b8e44c
Compare
|
Closing in favor of #49792. |
fabpot
added a commit
that referenced
this pull request
May 10, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [Scheduler] add `JitterTrigger` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #49806 | License | MIT | Doc PR | n/a I think this is what `@vtsykun` was trying to accomplish with #49806. FreeBSD has a `-jitter` option that does the same thing so I think there's precedent. From the (https://man.freebsd.org/cgi/man.cgi?cron): > -j jitter > Enable time jitter. Prior to executing commands, cron will sleep a random number of seconds in the range from 0 to jitter. ~This will not affect superuser jobs (see -J).~ A value for jitter must be between 0 and 60 inclusive. Default is 0, which effectively disables time jitter. > This option can help to smooth down system load spikes during mo- ments when a lot of jobs are likely to start at once, e.g., at the beginning of the first minute of each hour. Usage: ```php // defaults to 0-60 seconds $schedule->add(RecurringMessage::cron('`@daily`', $message1)->withJitter()); // customize the max seconds (0-30) $schedule->add(RecurringMessage::cron('`@daily`', $message1)->withJitter(30)); ``` Commits ------- b0d984b [Scheduler] add `JitterTrigger`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve problem of running things at midnight or once an hour at XX:00, to avoid loading peaks every hour/minutes.
Example usage