Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Fix tests getting enum from bag #48892

Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Fix tests getting enum from bag #48892

wants to merge 1 commit into from

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Jan 6, 2023 •
edited

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

This PR fixes two issues related to #48820’s tests:

  • it was impossible to run InputBagTest alone because it depended on the Foo enum defined in ParameterBagTest
  • the error message on invalid backing value changed with PHP 8.2 (Enum error message consistency php/php-src#9350). Not sure how to handle this one.

@carsonbot carsonbot added this to the 6.3 milestone Jan 6, 2023
@OskarStark
Copy link
Contributor

There is an open PR which looks fine to me for the exception message:

@MatTheCat MatTheCat closed this Jan 7, 2023
@MatTheCat MatTheCat deleted the bag-enum-tests branch January 7, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Deprecation HttpFoundation Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MatTheCat @OskarStark @carsonbot