Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fix profile search bar link query params #47417

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

HeahDude
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

Spotted while working on #47416.
The second argument of controller() is attributes.

@carsonbot
Copy link

Hey!

I think @Foxprodev has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Aug 31, 2022

Thank you @HeahDude.

@fabpot fabpot merged commit e76364c into symfony:5.4 Aug 31, 2022
@HeahDude HeahDude deleted the fix/profile-search-bar-link branch August 31, 2022 08:15
This was referenced Sep 30, 2022
chalasr added a commit that referenced this pull request Oct 23, 2022
…(HeahDude)

This PR was merged into the 6.2 branch.

Discussion
----------

[WebProfilerBundle] Fix profiler search link query params

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Reintroduce bug fix from #47417 after it was lost in 6.2 when #47148 was rebased and merged.

Commits
-------

aaff1d9 [WebProfilerBundle] Fix profiler search link query params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants