Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle][Validator] Deprecate annotation occurrences #51425

Merged
merged 1 commit into from Aug 22, 2023
Merged

[FrameworkBundle][Validator] Deprecate annotation occurrences #51425

merged 1 commit into from Aug 22, 2023

Conversation

alexandre-daubois
Copy link
Contributor

@alexandre-daubois alexandre-daubois commented Aug 18, 2023 •
edited by nicolas-grekas

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets Part of #51381
License MIT
Doc PR -
  • Deprecate framework.validation.enable_annotations in favor of framework.validation.enable_attributes
  • Deprecate framework.serializer.enable_annotations in favor of use framework.serializer.enable_attributes
  • Deprecate ValidatorBuilder::enableAnnotationMapping() in favor of ValidatorBuilder::enableAttributeMapping()
  • Deprecate ValidatorBuilder::disableAnnotationMapping() in favor of ValidatorBuilder::disableAttributeMapping()
  • Deprecate AnnotationLoader in favor of AttributeLoader

@carsonbot carsonbot added this to the 6.4 milestone Aug 18, 2023
@alexandre-daubois alexandre-daubois mentioned this pull request Aug 18, 2023
Closed
@stof
Copy link
Member

stof commented Aug 18, 2023

This should be in the same PR than #51426 instead of being a separate PR IMO, as this is about the FrameworkBundle semantic configuration related to the same change.
We don't require each PR to change only one of the packages. It is actually quite the opposite. The main reason to have a mono-repo is to allow to have one change spanning multiple packages.

@alexandre-daubois alexandre-daubois force-pushed the deprecate-enable-annotations branch 3 times, most recently from 97dc60e to 0bd8e1f Compare August 18, 2023 14:01
@alexandre-daubois alexandre-daubois force-pushed the deprecate-enable-annotations branch 3 times, most recently from 89a4e3c to 1723d35 Compare August 18, 2023 14:32
@alexandre-daubois
Copy link
Contributor Author

Addressed your comments @derrabus, thank you!

@derrabus
Copy link
Member

Thank you @alexandre-daubois.

@derrabus derrabus merged commit f354c1e into symfony:6.4 Aug 22, 2023
4 of 9 checks passed
@derrabus derrabus mentioned this pull request Aug 22, 2023
Closed
@alexandre-daubois
Copy link
Contributor Author

Working on the clean-up 👍

@derrabus derrabus mentioned this pull request Aug 22, 2023
Merged
@alexandre-daubois alexandre-daubois deleted the deprecate-enable-annotations branch August 22, 2023 13:30
This was referenced Aug 22, 2023
Merged
Closed
derrabus added a commit that referenced this pull request Aug 23, 2023
@derrabus
feature #51454 [Validator] Un-deprecate passing an annotation reader …
991d81e 
…to AnnotationLoader (derrabus)

This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] Un-deprecate passing an annotation reader to AnnotationLoader

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follow-up to #51425
| License       | MIT
| Doc PR        | N/A

#51425 deprecated the `AnnotationLoader` class and its replacement already does not accept an annotation reader anymore. Thus, the deprecation of the constructor parameter is redundant, which is why I propose to take it back.

cc `@alexandre`-daubois

Commits
-------

4fa1d32 [Validator] Un-deprecate passing an annotation reader to AnnotationLoader
nicolas-grekas added a commit that referenced this pull request Aug 23, 2023
@nicolas-grekas
minor #51455 [FrameworkBundle][Validator] Remove remaining deprecatio…
056c66e 
…ns (alexandre-daubois)

This PR was merged into the 7.0 branch.

Discussion
----------

[FrameworkBundle][Validator] Remove remaining deprecations

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#18781

Follow-up of #51425

Commits
-------

6e8cab7 [FrameworkBundle][Validator] Remove remaining deprecations
@alamirault alamirault mentioned this pull request Sep 5, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
@lyrixx
Copy link
Member

lyrixx commented Oct 25, 2023

see #52287

@alexandre-daubois
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@mtarld mtarld mtarld approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Deprecation FrameworkBundle Status: Reviewed Validator
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexandre-daubois @stof @derrabus @lyrixx @nicolas-grekas @mtarld @carsonbot