Create AttributeLoader instead use AnnotationLoader

[alamirault]

Description

Today, symfony AnnotationLoader load for Doctrine annotations and PHP 8 attributes.

For new projects, only attributes are enough and keep naming AnnotationLoader can confuse (load also attributes).

WDYT about creating AttributeLoader ?

Some files and impacts:

Symfony\Component\Validator\Mapping\Loader\AnnotationLoader -> New class Symfony\Component\Validator\Mapping\Loader\AttributeLoader :

• Symfony\Component\Validator::enableAnnotationMapping() -> Introduce new method enableAttributeMapping
• New boolean node in framework configuration: enable_attributes

Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader -> New class Symfony\Component\Serializer\Mapping\Loader\AttributeLoader:

• New boolean node in framework configuration: enable_attributes

Example

No response

[GromNaN]

Hello, the Doctrine Annotations Reader is an optional dependency of Symfony\Component\Validator\Mapping\Loader\AttributeLoader. When the package doctrine/annotations is not installed, only attributes are read.

Do you need an explicit way to disable the annotation? What is the benefit of disabling reading annotations when doctrine/annotations is installed?

Here is the code that could be updated to disable annotation reader with a new option:

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines 1524 to 1529 in c79d4ab

	if (\array_key_exists('enable_annotations', $config) && $config['enable_annotations']) {
	$validatorBuilder->addMethodCall('enableAnnotationMapping', [true]);
	if ($this->isInitializedConfigEnabled('annotations')) {
	$validatorBuilder->addMethodCall('setDoctrineAnnotationReader', [new Reference('annotation_reader')]);
	}
	}

[derrabus]

If we deprecate Doctrine Annotations completely, renaming classes, methods etc. would be the next logical step. But not before that.

[alamirault]

This PR #49358 and following Renaming will fix this issue

[derrabus]

This PR #49358 and following Renaming will fix this issue

For Routing, yes. We would need to do the same for Serializer and Validator then.

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[alamirault]

It's done in #51425. Thanks @alexandre-daubois