[Mailer] Allow overriding default eSMTP authenticators #49900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoetzsch
approved these changes
Apr 3, 2023
fabpot
approved these changes
Apr 14, 2023
|
Thank you @cedric-anne. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMTP authentication using OAuth token on Azure servers is really long, due to high latency responses from the SMTP server (probably to prevent brute-force attacks).
Indeed, a
AUTH LOGINcommand is sent first, and have to wait for about 5 seconds get the error response back. Then aRSETcommand is sent and also have to wait for about 5 seconds get a response back. TheAUTH XOAUTH2command is then sent and all is fast after that.Adding the ability to override default eSMTP authenticators will permit developers to explicitely define that only
XOAUTH2authenticator has to be used, to prevent high latency in SMTP authentication.I will update the documentation once new methods signatures will be validated.