Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Allow overriding default eSMTP authenticators #18209

Closed
fabpot opened this issue Apr 14, 2023 · 2 comments
Closed

[Mailer] Allow overriding default eSMTP authenticators #18209

fabpot opened this issue Apr 14, 2023 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Mailer
Milestone
6.3

Comments

@fabpot
Copy link
Member

fabpot commented Apr 14, 2023

Q A
Feature PR symfony/symfony#49900
PR author(s) @cedric-anne
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 6.3 milestone Apr 14, 2023
@cedric-anne cedric-anne mentioned this issue Apr 14, 2023
Merged
@cedric-anne
Copy link
Contributor

Documentation update proposed in #18212. Not sure if it is required to document both constructor param update and setAuthenticators() method. Indeed, code snippet seems a bit weird with both.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 23, 2023
javiereguiluz added a commit that referenced this issue May 5, 2023
@javiereguiluz
minor #18212 [Mailer] Document EsmtpTransport::setAuthenticators() …
537c441 
…(cedric-anne)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Mailer] Document `EsmtpTransport::setAuthenticators()`

See #18209

Commits
-------

4fd5f27 [Mailer] Document `EsmtpTransport::setAuthenticators()`
@javiereguiluz
Copy link
Member

Closing as fixed in #18212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Mailer
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @xabbuh @carsonbot @cedric-anne