[Form] [ChoiceType] Add a placeholder_attr option
#48343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
placeholder_attr optionplaceholder_attr option
|
Hey! I think @Gemorroj has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Thoughts ? |
xabbuh
reviewed
Mar 17, 2023
src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Mar 17, 2023
src/Symfony/Bridge/Twig/Resources/views/Form/foundation_5_layout.html.twig
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Mar 19, 2023
fabpot
approved these changes
Apr 8, 2023
|
Thank you @elementaire. |
|
This may have some relationship to #45727 |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 6, 2023
…elementaire) This PR was merged into the 6.3 branch. Discussion ---------- [Form] Add a `placeholder_attr` option to `ChoiceType` PR symfony/symfony#48343 Commits ------- 8fcd394 Add a placeholder_attr option to ChoiceType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to custom the attributes of the placeholder (
data-*,title,disabled, etc.).