[Form] Add a placeholder_attr option to ChoiceType
#17469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elementaire
changed the title
placeholder_attr option to ChoiceType
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 8, 2023
…lementaire) This PR was merged into the 6.3 branch. Discussion ---------- [Form] [ChoiceType] Add a `placeholder_attr` option | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #38958 | Similar Pull Request | #47570 | License | MIT | Doc PR | symfony/symfony-docs#17469 Allow to custom the attributes of the placeholder (`data-*`, `title`, `disabled`, etc.). Commits ------- 2d4396a [Form][ChoiceType] Add placeholder_attr field option
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Apr 8, 2023
…lementaire) This PR was merged into the 6.3 branch. Discussion ---------- [Form] [ChoiceType] Add a `placeholder_attr` option | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #38958 | Similar Pull Request | #47570 | License | MIT | Doc PR | symfony/symfony-docs#17469 Allow to custom the attributes of the placeholder (`data-*`, `title`, `disabled`, etc.). Commits ------- 2d4396ad50 [Form][ChoiceType] Add placeholder_attr field option
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Apr 8, 2023
…lementaire) This PR was merged into the 6.3 branch. Discussion ---------- [Form] [ChoiceType] Add a `placeholder_attr` option | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #38958 | Similar Pull Request | #47570 | License | MIT | Doc PR | symfony/symfony-docs#17469 Allow to custom the attributes of the placeholder (`data-*`, `title`, `disabled`, etc.). Commits ------- 2d4396ad50 [Form][ChoiceType] Add placeholder_attr field option
javiereguiluz
removed
the
Waiting Code Merge
javiereguiluz
changed the title
placeholder_attr option to ChoiceTypeplaceholder_attr option to ChoiceType
|
@elementaire thanks for contributing this feature and its docs. I'm sorry it took us so long to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR symfony/symfony#48343