Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #54080 [Routing] Enhance error handling in StaticPrefixCollection…
… for compatibility with libpcre2-10.43 (Lustmored) This PR was merged into the 5.4 branch. Discussion ---------- [Routing] Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43 The error handling function in the StaticPrefixCollection class has been extended. A new check for 'Compilation failed: length of lookbehind assertion is not limited' message error was added to improve the error capture process. | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54067 | License | MIT Recent changes in libpcre2 have changed the error message we are trying to catch in StaticPrefixCollection. The change comes from this commit (please take a look at changes in `src/pcre2_error.c`): PCRE2Project/pcre2@1e78b77 This PR checks for both possible error messages for backwards-compatible way of handling errors. I did not add any tests as current tests are throwing PHP warnings when run with newer libpcre2, which are gone after the proposed change and I'm unsure how to proceed with that fact. Commits ------- 7183330 Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43
- Loading branch information