last improvements

symfony · Oct 19, 2023 · 91da8a7 · 91da8a7
1 parent 4851495
commit 91da8a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/src/Symfony/Component/Validator/Constraints/GroupSequenceProvider.php b/src/Symfony/Component/Validator/Constraints/GroupSequenceProvider.php
@@ -11,22 +11,25 @@
 
 namespace Symfony\Component\Validator\Constraints;
 
+use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor;
+use Symfony\Component\Validator\Attribute\HasNamedArguments;
+
 /**
  * Attribute to define a group sequence provider.
  *
  * @Annotation
  *
+ * @NamedArgumentConstructor
+ *
  * @Target({"CLASS", "ANNOTATION"})
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
 #[\Attribute(\Attribute::TARGET_CLASS)]
 class GroupSequenceProvider
 {
-    public ?string $provider = null;
-
-    public function __construct(array $options = [], string $provider = null)
+    #[HasNamedArguments]
+    public function __construct(public ?string $provider = null)
     {
-        $this->provider = $options['provider'] ?? $provider;
     }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceProviderTest.php b/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceProviderTest.php
@@ -17,13 +17,6 @@
 
 class GroupSequenceProviderTest extends TestCase
 {
-    public function testCreate()
-    {
-        $sequence = new GroupSequenceProvider(['provider' => DummyGroupProvider::class]);
-
-        $this->assertSame(DummyGroupProvider::class, $sequence->provider);
-    }
-
     public function testCreateAttributeStyle()
     {
         $sequence = new GroupSequenceProvider(provider: DummyGroupProvider::class);