[Twig] Add app.locale documentation
#18190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
the
Waiting Code Merge
OskarStark
approved these changes
Apr 11, 2023
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 11, 2023
…iable` (SVillette) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [TwigBridge][TwigBundle] Add current locale to `AppVariable` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #49870 | License | MIT | Doc PR | symfony/symfony-docs#18190 As stated in #49870, they were no way to get the current locale without passing it through a variable when rendering a template within `LocaleSwitcher::runWithLocale()`. ```php #[AsController] final class HomeController { #[Route('/', name: 'app_home')] public function __invoke(LocaleSwitcher $localeSwitcher, Environment $twig): Response { $localeSwitcher->setLocale('en'); return $localeSwitcher->runWithLocale('fr', function () use ($twig) { return new Response($twig->render('index.html.twig')); }); } } ``` ```twig {{ app.locale }} // fr ``` A doc PR will be submitted if this change is accepted. Commits ------- 2371216 [TwigBridge][TwigBundle] Add current locale to `AppVariable`
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Apr 11, 2023
…iable` (SVillette) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [TwigBridge][TwigBundle] Add current locale to `AppVariable` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #49870 | License | MIT | Doc PR | symfony/symfony-docs#18190 As stated in #49870, they were no way to get the current locale without passing it through a variable when rendering a template within `LocaleSwitcher::runWithLocale()`. ```php #[AsController] final class HomeController { #[Route('/', name: 'app_home')] public function __invoke(LocaleSwitcher $localeSwitcher, Environment $twig): Response { $localeSwitcher->setLocale('en'); return $localeSwitcher->runWithLocale('fr', function () use ($twig) { return new Response($twig->render('index.html.twig')); }); } } ``` ```twig {{ app.locale }} // fr ``` A doc PR will be submitted if this change is accepted. Commits ------- 2371216d93 [TwigBridge][TwigBundle] Add current locale to `AppVariable`
SVillette
changed the title
app.locale documentationapp.locale documentation
|
Hi @OskarStark @javiereguiluz, Just a friendly ping to inform you that the feature PR is merged now. I think the label |
OskarStark
approved these changes
Apr 14, 2023
carsonbot
changed the title
app.locale documentationapp.locale documentation
OskarStark
changed the title
app.locale documentationapp.locale documentation
|
Thanks Samaël for working on this feature, this is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add documentation of symfony/symfony#49913