Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Document the new NoSuspiciousCharacters constraint #17897

Merged

Conversation

MatTheCat
Copy link
Contributor

Feature PR: symfony/symfony#49300

@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch from edba633 to 40c94ec Compare February 14, 2023 11:04
@MatTheCat MatTheCat marked this pull request as ready for review February 14, 2023 11:06
@carsonbot carsonbot modified the milestones: next, 6.3 Feb 14, 2023
@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch 2 times, most recently from 05f566e to 2792c27 Compare February 14, 2023 11:38
@xabbuh xabbuh modified the milestones: 6.3, next Feb 16, 2023
@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch from 47d2e1b to 22b3e54 Compare February 16, 2023 08:28
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Feb 21, 2023
…to validate a string is not suspicious (MatTheCat)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not suspicious

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49268
| License       | MIT
| Doc PR        | symfony/symfony-docs#17897

Leverage `Spoofchecker::isSuspicious` in a new constraint.

Commits
-------

12f901f [Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not a spoof attempt
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Feb 21, 2023
…to validate a string is not suspicious (MatTheCat)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not suspicious

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49268
| License       | MIT
| Doc PR        | symfony/symfony-docs#17897

Leverage `Spoofchecker::isSuspicious` in a new constraint.

Commits
-------

12f901f438 [Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not a spoof attempt
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Feb 21, 2023
…to validate a string is not suspicious (MatTheCat)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not suspicious

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49268
| License       | MIT
| Doc PR        | symfony/symfony-docs#17897

Leverage `Spoofchecker::isSuspicious` in a new constraint.

Commits
-------

12f901f438 [Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not a spoof attempt
@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch from 22b3e54 to 019c23f Compare February 27, 2023 09:25
@MatTheCat
Copy link
Contributor Author

The feature got merged 🎉

@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Mar 1, 2023

The ``NoSuspiciousCharacters`` constraint was introduced in Symfony 6.3.

..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment, and therefore not rendered on the website, am I correct @wouterj @javiereguiluz ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so! I was following https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#block-quotes

Empty comments may be used to explicitly terminate preceding constructs that would otherwise consume a block quote

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Oskar meant is that this content is a comment that won't be rendered on symfony.com. I've reworded it a bit to add it to the normal text so people can read it.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be added to reference/constraints.rst

reference/constraints/NoSuspiciousCharacters.rst Outdated Show resolved Hide resolved
reference/constraints/NoSuspiciousCharacters.rst Outdated Show resolved Hide resolved
reference/constraints/NoSuspiciousCharacters.rst Outdated Show resolved Hide resolved
MatTheCat pushed a commit to MatTheCat/symfony-docs that referenced this pull request Mar 2, 2023
@MatTheCat
Copy link
Contributor Author

Should also be added to reference/constraints.rst

Done, thanks for the heads-up

MatTheCat pushed a commit to MatTheCat/symfony-docs that referenced this pull request Mar 3, 2023
@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch from a35e0c8 to 69a1ddd Compare March 3, 2023 11:35
MatTheCat pushed a commit to MatTheCat/symfony-docs that referenced this pull request Mar 11, 2023
@MatTheCat MatTheCat force-pushed the no-suspicious-characters-constraint branch from 69a1ddd to 8453ee2 Compare March 11, 2023 10:19
@carsonbot carsonbot changed the title Document the new NoSuspiciousCharacters constraint [Validator] Document the new NoSuspiciousCharacters constraint Mar 22, 2023
@javiereguiluz javiereguiluz modified the milestones: next, 6.3 Mar 22, 2023
@javiereguiluz javiereguiluz force-pushed the no-suspicious-characters-constraint branch from 8453ee2 to e4d1b82 Compare March 22, 2023 16:34
@javiereguiluz javiereguiluz merged commit 8fab448 into symfony:6.3 Mar 22, 2023
@javiereguiluz
Copy link
Member

Mathieu, this was a fantastic contribution and a great feature! Thanks a lot for contributing it.

@MatTheCat MatTheCat deleted the no-suspicious-characters-constraint branch March 22, 2023 17:28
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Jul 28, 2023
…to validate a string is not suspicious (MatTheCat)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not suspicious

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49268
| License       | MIT
| Doc PR        | symfony/symfony-docs#17897

Leverage `Spoofchecker::isSuspicious` in a new constraint.

Commits
-------

12f901f438 [Validator] Add a `NoSuspiciousCharacters` constraint to validate a string is not a spoof attempt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants