[ExpressionLanguage] Add enum expression function
#17632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 30, 2022
OskarStark
reviewed
Dec 30, 2022
| syntax as PHP and JavaScript. The ExpressionLanguage component comes with one | ||
| function by default: ``constant()``, which will return the value of the PHP | ||
| constant:: | ||
| syntax as PHP and JavaScript. The ExpressionLanguage component comes with two |
There was a problem hiding this comment.
Let's remove the "two" and use "following functions"...
This way we don't need to adapt it for further methods in the future
| function by default: ``constant()``, which will return the value of the PHP | ||
| constant:: | ||
| syntax as PHP and JavaScript. The ExpressionLanguage component comes with two | ||
| functions by default. The first one is ``constant()``, which will return the |
There was a problem hiding this comment.
Maybe let's use headlines instead of the introduction with "the first..." and "the second"?
There was a problem hiding this comment.
Updated, as well as your previous feedback!
javiereguiluz
added
the
Waiting Code Merge
alexandre-daubois
force-pushed
the
feat/expression-language-enum
branch
from
6797b62
to
1ac5815
Compare
OskarStark
approved these changes
Jan 2, 2023
| Constant function | ||
| ~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This function will return the value of the PHP constant:: |
There was a problem hiding this comment.
Suggested change
| This function will return the value of the PHP constant:: | |
| This function will return the value of a PHP constant:: |
Kann you also add an example for a class with a namespace? Thanks
alexandre-daubois
force-pushed
the
feat/expression-language-enum
branch
from
1ac5815
to
8f1976e
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jan 9, 2023
…lexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [ExpressionLanguage] Add `enum` expression function | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #48593 | License | MIT | Doc PR | symfony/symfony-docs#17632 Commits ------- 53bfee4 [ExpressionLanguage] Add `enum` expression function
symfony-splitter
pushed a commit
to symfony/expression-language
that referenced
this pull request
Jan 9, 2023
…lexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [ExpressionLanguage] Add `enum` expression function | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #48593 | License | MIT | Doc PR | symfony/symfony-docs#17632 Commits ------- 53bfee4440 [ExpressionLanguage] Add `enum` expression function
OskarStark
reviewed
Jan 9, 2023
| * ``constant()`` | ||
| * ``enum()`` | ||
|
|
||
| Constant function |
There was a problem hiding this comment.
Suggested change
| Constant function | |
| ``constant()`` function |
?
There was a problem hiding this comment.
I agree this is better! I'm doing the change, and I'll revert it if Wouter and/or Javier don't agree! 🙂
OskarStark
reviewed
Jan 9, 2023
| This will print out ``root``. | ||
|
|
||
| Enum function |
There was a problem hiding this comment.
Suggested change
| Enum function | |
| ``enum()`` function |
? WDYT @wouterj @javiereguiluz
alexandre-daubois
force-pushed
the
feat/expression-language-enum
branch
from
8f1976e
to
f3c194c
Compare
OskarStark
reviewed
Jan 10, 2023
|
|
||
| define('DB_USER', 'root'); | ||
|
|
||
| var_dump($expressionLanguage->evaluate( | ||
| 'constant("DB_USER")' | ||
| )); | ||
|
|
||
| // This also works with class constants |
There was a problem hiding this comment.
Let's make this a plain text followed by a new code block and add a namespace for the class.
Maybe let's not reuse DB_USER
OskarStark
reviewed
Jan 10, 2023
|
|
||
| This function will return the case of an enumeration:: | ||
|
|
||
| enum Foo |
|
PR header still referencing quadruple |
alexandre-daubois
force-pushed
the
feat/expression-language-enum
branch
from
f3c194c
to
42dc551
Compare
|
That's fixed! 🙂 |
OskarStark
approved these changes
Jan 10, 2023
|
Thanks for your work on this new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#48669.
ℹ️ I added a namespace to the enum in the example to kind of remind that triple backslashes must be used in the expression to use the namespaced enum.