Skip to content

[make:twig-component] Fix generated twig file location #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IndraGunawan
Copy link
Contributor

this PR aims to fix generated twig file path if the twig-component created on a subdirectory

Before

 symfony console make:twig-component "Form\Input" --live
 created: src/Twig/Components/Form/Input.php
 created: templates/components/Input.html.twig

  Success!

 To render the component, use <twig:Input />.

After

symfony console make:twig-component "Form\Input" --live
 created: src/Twig/Components/Form/Input.php
 created: templates/components/Form/Input.html.twig

  Success!

 To render the component, use <twig:Form:Input />.

Verified

This commit was signed with the committer’s verified signature.
dariakp Daria Pardue
@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels Jun 4, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @IndraGunawan

@jrushlow jrushlow added this to the v1.60.0 milestone Jun 4, 2024
@jrushlow jrushlow merged commit 10459ae into symfony:main Jun 5, 2024
8 checks passed
@IndraGunawan IndraGunawan deleted the fix-generated-template-file-location branch June 5, 2024 03:52
@jrushlow jrushlow mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants