Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:controller] remove CodeExtension::getFileLink() call when generating twig templates #1419

Merged
merged 2 commits into from Jan 26, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Jan 23, 2024

TwigBridge's CodeExtension was made @internal via symfony/twig-bridge@76b4393

  • removes file link anchor in generated template to the controller and template
  • deprecates GeneratorTwigHelper::getFileLink()

fixes #1415

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer Related Tests Pass and removed Status: Needs Review Needs to be reviewed labels Jan 26, 2024
@jrushlow jrushlow merged commit 0666ff8 into symfony:main Jan 26, 2024
6 of 7 checks passed
@jrushlow jrushlow deleted the bug/file-link branch January 26, 2024 14:06
@jrushlow jrushlow mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Related Tests Pass Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace or remove "file_link" filter ?
2 participants