Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): invalid message on card-control #2978

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(styles): invalid message on card-control #2978

wants to merge 5 commits into from

Conversation

davidritter-dotcom
Copy link
Contributor

No description provided.

@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner April 18, 2024 15:15
@davidritter-dotcom davidritter-dotcom linked an issue Apr 18, 2024 that may be closed by this pull request
Create form-control-invalid-message CSS-only component #2625
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited

⚠️ No Changeset found

Latest commit: a092c3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 18, 2024 •
edited

Preview environment ready: https://preview-2978--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2978--swisspost-design-system-next.netlify.app

@oliverschuerch
Copy link
Contributor

oliverschuerch commented Apr 19, 2024 •
edited

There is an open PR for merging the card-control stories. Please do not merge this PR before the other (#2847)!

@oliverschuerch oliverschuerch added the 🚂 PR train PR which follows another one. label Apr 19, 2024
@davidritter-dotcom
feat(styles): fix linting issues
e6af759
@davidritter-dotcom
Merge branch 'main' into 2625-create-form-control-invalid-message-css…
3517f43 
…-only-component

# Conflicts:
#	packages/documentation/src/stories/components/forms/card-control/web-component/card-control.stories.ts
#	packages/documentation/src/stories/components/forms/choice-card/choice-card.ts
@davidritter-dotcom
fix(documentation): invalid message fix on card-control story
e6b234e
@gfellerph gfellerph removed their request for review May 2, 2024 14:10
oliverschuerch
oliverschuerch requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something looks wrong with the icon placement
image

Tested on the css-component (web-component looks good).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidritter-dotcom
Copy link
Contributor Author

I've only added the icon in the message on the form elements who don't have an icon inside in this PR, but since the icon inside gets removed everywhere, the icon would need to be added everywhere in the validation message.

oliverschuerch
oliverschuerch requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset!

packages/styles/src/components/form-validation.scss
Comment on lines +69 to +70
post-card-control ~ .invalid-feedback {
display: inline-flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be part of the post-card-control.scss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create form-control-invalid-message CSS-only component
3 participants
@davidritter-dotcom @swisspost-bot @oliverschuerch