Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): Update buttons colors #2977

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Apr 18, 2024

No description provided.

@imagoiq imagoiq self-assigned this Apr 18, 2024
@imagoiq imagoiq requested a review from a team as a code owner April 18, 2024 13:13
@imagoiq imagoiq requested a review from gfellerph April 18, 2024 13:13
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: a662a4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imagoiq imagoiq linked an issue Apr 18, 2024 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 18, 2024

Preview environment ready: https://preview-2977--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2977--swisspost-design-system-next.netlify.app

Comment on lines +27 to +28
&:where(#{color.$dark-backgrounds}),
:where(#{color.$dark-backgrounds}) & {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big change, this was necessary to be able to keep style for button with specific color background (e.g. .btn-petrol-bright). This mixin was changed recently to support post-aler[type"..."] and this change the specificity as it adds one element to the list of classes, and then override the style for the specific color background.

@imagoiq
Copy link
Contributor Author

imagoiq commented Apr 18, 2024

@rouvenpost I need your design review to check if it's correct and if I didn't miss any change.

@rouvenpost
Copy link

rouvenpost commented Apr 18, 2024

I think we should remove the «Accent colors» Section altogether. They should not be used anymore.

@imagoiq
Copy link
Contributor Author

imagoiq commented Apr 18, 2024

I think we should remove the «Accent colors» Section altogether. They should not be used anymore.

You're right. They will be deprecated with this ticket: #2863

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imagoiq imagoiq assigned gfellerph and unassigned imagoiq Apr 25, 2024
@gfellerph gfellerph requested review from alizedebray and removed request for gfellerph May 2, 2024 14:10
@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 29, 2024

Related Previews

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles: Update buttons
4 participants