-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): Update buttons colors #2977
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a662a4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview environment ready: https://preview-2977--swisspost-web-frontend.netlify.app |
&:where(#{color.$dark-backgrounds}), | ||
:where(#{color.$dark-backgrounds}) & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big change, this was necessary to be able to keep style for button with specific color background (e.g. .btn-petrol-bright
). This mixin was changed recently to support post-aler[type"..."]
and this change the specificity as it adds one element to the list of classes, and then override the style for the specific color background.
@rouvenpost I need your design review to check if it's correct and if I didn't miss any change. |
I think we should remove the «Accent colors» Section altogether. They should not be used anymore. |
You're right. They will be deprecated with this ticket: #2863 |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
No description provided.