Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation, styles): Update textarea styles and add floating label small variant #2857

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat(documentation, styles): Update textarea styles and add floating label small variant #2857

wants to merge 23 commits into from

Conversation

davidritter-dotcom
Copy link
Contributor

I updated the styles to be as close to figma as possible, but since some paddings in figma don't match any post-size, there will be some differences.

@davidritter-dotcom
feat(documentation, styles): some small changes
11fd926
@davidritter-dotcom
feat(styles): padding ajustment
512a869 
form-control-lg
@davidritter-dotcom
Revert "feat(styles): padding ajustment"
a8472eb 
This reverts commit 512a869.
@davidritter-dotcom
Revert "feat(documentation, styles): some small changes"
3f0d8aa 
This reverts commit 11fd926.
@davidritter-dotcom
Merge branch 'main' into 1834-update-textarea-styles
996f8e7
@davidritter-dotcom
feat(docs): docs and story
1928f9d
@davidritter-dotcom
feat(styles): floating label large
40bb3ef
@davidritter-dotcom
feat(styles, documentation): floating label styles for small variant
42185c2
@davidritter-dotcom
feat(styles): validation states and label size
c610877
@davidritter-dotcom
feat(styles): disabled styles
1d56366
@davidritter-dotcom
Merge branch 'main' into 1834-update-textarea-styles
8568e9b
@davidritter-dotcom
feat(styles): textarea and input disabled state and focus
05723e7
@davidritter-dotcom
feat(styles): validated styles and accessibility test
74bbcde
@davidritter-dotcom
feat(styles): small change
6120bee
@davidritter-dotcom
Merge branch 'main' into 1834-update-textarea-styles
45a15ef
@davidritter-dotcom
feat(styles): textarea styles update
7b0dd3e
@davidritter-dotcom
feat(styles): min height fix
771d6f0
@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner March 27, 2024 13:28
@davidritter-dotcom davidritter-dotcom linked an issue Mar 27, 2024 that may be closed by this pull request
Styles: Update textarea #1055
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited

⚠️ No Changeset found

Latest commit: c1dfb97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@davidritter-dotcom davidritter-dotcom linked an issue Mar 27, 2024 that may be closed by this pull request
Update textarea styles #1834
Open
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 27, 2024 •
edited

Preview environment ready: https://preview-2857--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2857--swisspost-design-system-next.netlify.app

@oliverschuerch oliverschuerch force-pushed the 1834-update-textarea-styles branch 2 times, most recently from 98e9ff7 to 2116d9e Compare April 16, 2024 14:45
@oliverschuerch
chore: add update
594a769
@oliverschuerch
Merge branch 'main' into 1834-update-textarea-styles
be0bd1b 
# Conflicts:
#	packages/styles/src/components/form-validation.scss
#	packages/styles/src/components/forms.scss
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidritter-dotcom davidritter-dotcom mentioned this pull request Apr 23, 2024
Open
oliverschuerch
oliverschuerch requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow this discussion: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=7779-34916&mode=design&t=MZFCh0b62SndmXX9-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update textarea styles Styles: Update textarea
3 participants
@davidritter-dotcom @swisspost-bot @oliverschuerch