Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark services documentation #73

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

Kayzz99
Copy link
Contributor

@Kayzz99 Kayzz99 commented Mar 28, 2024

No description provided.

@Kayzz99 Kayzz99 requested a review from andrptrc March 28, 2024 09:58
@Kayzz99 Kayzz99 self-assigned this Mar 28, 2024
@Kayzz99 Kayzz99 linked an issue Mar 28, 2024 that may be closed by this pull request
docs/reference/index.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@Kayzz99 Kayzz99 requested a review from andrptrc March 28, 2024 10:08
@rmarquis
Copy link
Contributor

rmarquis commented Mar 28, 2024

The documentation CI/CD pipeline fails because of a regression, related to this issue: squidfunk/mkdocs-material#5628

Namely, mkdocs tries to download the Roboto font which doesn't return a zip file when downloaded programatically (with curl or wget). A few projects seem to be affected by this regression lately.

A temporary workaround could be to disable the social plugin of mkdoc, but I am not sure which part of the docs relies on that plugin.

@rmarquis rmarquis changed the title add bencharmark services documentation add benchmark services documentation Mar 28, 2024
@rmarquis rmarquis force-pushed the 71-add-documentation-in-references-for-new-services branch from 3c0bed9 to 73bffaf Compare April 2, 2024 14:47
@rmarquis rmarquis force-pushed the 71-add-documentation-in-references-for-new-services branch from 73bffaf to 8b8f52d Compare April 2, 2024 15:02
@rmarquis
Copy link
Contributor

rmarquis commented Apr 2, 2024

The upstream issue with teh social plugin has been fixed today (see squidfunk/mkdocs-material#6983). Updating to this new mkdocs-material release and merging.

@rmarquis rmarquis merged commit 23c8df1 into main Apr 2, 2024
2 checks passed
@rmarquis rmarquis deleted the 71-add-documentation-in-references-for-new-services branch April 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation in References for new services
3 participants