Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix evaluation of array literals with void 0 #8733

Merged
merged 3 commits into from Mar 12, 2024
Merged

fix(es/minifier): Fix evaluation of array literals with void 0 #8733

merged 3 commits into from Mar 12, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 12, 2024

@kdy1 kdy1 added this to the Planned milestone Mar 12, 2024
@kdy1 kdy1 self-assigned this Mar 12, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024 •
edited

⚠️ No Changeset found

Latest commit: 45e8e1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented Mar 12, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_utils

@kdy1 kdy1 marked this pull request as ready for review March 12, 2024 03:51
@kdy1 kdy1 requested a review from a team as a code owner March 12, 2024 03:51
@kdy1 kdy1 merged commit aa0154d into swc-project:main Mar 12, 2024
144 checks passed
@kdy1 kdy1 deleted the issue-8706 branch March 12, 2024 05:58
This was referenced Mar 12, 2024
Merged
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.4.7 Mar 13, 2024
kdy1 added a commit to vercel/turbo that referenced this pull request Mar 13, 2024
@kdy1
chore: Update swc_core to v0.90.21 (#7672)
dbe2134 
### Description

- Update `swc_core` to fix performance regression caused by the creation
of the `tokio` runtime.

 - Apply various minifier bugfixes.

   - swc-project/swc#8730
   - swc-project/swc#8733
   - swc-project/swc#8725
   - swc-project/swc#8726
   - swc-project/swc#8727

- Apply swc-project/plugins#271 (Closes PACK-2714)

### Testing Instructions



Closes PACK-2693
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2024
@kdy1 @sokra
chore: Update swc_core to v0.90.21 (#63031)
013ba06 
### What?

- Update `swc_core` to fix performance regression caused by the creation
of the `tokio` runtime.

This PR practically reverts
#62441.

 - Apply various minifier bug fixes.

   - swc-project/swc#8730
   - swc-project/swc#8733
   - swc-project/swc#8725
   - swc-project/swc#8726
   - swc-project/swc#8727

- Apply swc-project/plugins#271 (Closes
PACK-2714)


### Why?

Someone reported a performance regression. See
swc-project/swc#8708

### How?

Closes PACK-2693

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Austaras Austaras Austaras approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.7
Development

Successfully merging this pull request may close these issues.

Minifier converts array to string value incorrectly when void 0 is in array
2 participants
@kdy1 @Austaras