fix(es/minifier): Fix eval of toString of array with holes
#8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kdy1
changed the title
toString of array with holestoString of array with holes
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
swc-bot
reviewed
Mar 11, 2024
This was referenced Mar 12, 2024
kdy1
added a commit
to vercel/turbo
that referenced
this pull request
Mar 13, 2024
### Description - Update `swc_core` to fix performance regression caused by the creation of the `tokio` runtime. - Apply various minifier bugfixes. - swc-project/swc#8730 - swc-project/swc#8733 - swc-project/swc#8725 - swc-project/swc#8726 - swc-project/swc#8727 - Apply swc-project/plugins#271 (Closes PACK-2714) ### Testing Instructions Closes PACK-2693
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2024
### What? - Update `swc_core` to fix performance regression caused by the creation of the `tokio` runtime. This PR practically reverts #62441. - Apply various minifier bug fixes. - swc-project/swc#8730 - swc-project/swc#8733 - swc-project/swc#8725 - swc-project/swc#8726 - swc-project/swc#8727 - Apply swc-project/plugins#271 (Closes PACK-2714) ### Why? Someone reported a performance regression. See swc-project/swc#8708 ### How? Closes PACK-2693 --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue:
toStringof array containing 1-empty hole to invalid expression whenunsafeis true #8717.