Skip to content

Commit

Permalink
fix(es/minifier): Do not evaluate slice calls with negative index (#…
Browse files Browse the repository at this point in the history
…8726)

**Related issue:**

 - Closes #8715.
  • Loading branch information
kdy1 committed Mar 11, 2024
1 parent 99a5961 commit 23f9635
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 0 deletions.
12 changes: 12 additions & 0 deletions crates/swc_ecma_minifier/src/compress/pure/evaluate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ impl Pure<'_> {
if let Value::Known(start) =
call.args[0].expr.as_pure_number(&self.expr_ctx)
{
if start.is_sign_negative() {
return;
}

let start = start.floor() as usize;

self.changed = true;
Expand All @@ -98,9 +102,17 @@ impl Pure<'_> {
let start = call.args[0].expr.as_pure_number(&self.expr_ctx);
let end = call.args[1].expr.as_pure_number(&self.expr_ctx);
if let Value::Known(start) = start {
if start.is_sign_negative() {
return;
}

let start = start.floor() as usize;

if let Value::Known(end) = end {
if end.is_sign_negative() {
return;
}

let end = end.floor() as usize;
let end = end.min(arr.elems.len());

Expand Down
47 changes: 47 additions & 0 deletions crates/swc_ecma_minifier/tests/fixture/issues/8715/config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"defaults": true,
"arguments": false,
"arrows": true,
"booleans": true,
"booleans_as_integers": false,
"collapse_vars": true,
"comparisons": true,
"computed_props": true,
"conditionals": true,
"dead_code": true,
"directives": true,
"drop_console": false,
"drop_debugger": true,
"evaluate": true,
"expression": false,
"hoist_funs": false,
"hoist_props": true,
"hoist_vars": false,
"if_return": true,
"join_vars": true,
"keep_classnames": false,
"keep_fargs": true,
"keep_fnames": false,
"keep_infinity": false,
"loops": true,
"negate_iife": true,
"properties": true,
"reduce_funcs": false,
"reduce_vars": false,
"side_effects": true,
"switches": true,
"typeofs": true,
"unsafe": false,
"unsafe_arrows": false,
"unsafe_comps": false,
"unsafe_Function": false,
"unsafe_math": false,
"unsafe_symbols": false,
"unsafe_methods": false,
"unsafe_proto": false,
"unsafe_regexp": false,
"unsafe_undefined": false,
"unused": true,
"const_to_let": true,
"pristine_globals": true
}
2 changes: 2 additions & 0 deletions crates/swc_ecma_minifier/tests/fixture/issues/8715/input.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
console.log([1, 2, 3].slice(-1))
console.log([1, 2, 3].slice(-1, 0))
9 changes: 9 additions & 0 deletions crates/swc_ecma_minifier/tests/fixture/issues/8715/output.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
console.log([
1,
2,
3
].slice(-1)), console.log([
1,
2,
3
].slice(-1, 0));

0 comments on commit 23f9635

Please sign in to comment.