-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generic model compatible with PHP 8.1 #11846
Conversation
Add #[\ReturnTypeWillChange] (https://php.watch/versions/8.1/ReturnTypeWillChange) to avoid deprecation notices.
Hello, is there any way we can have it merged? It seems to be a valid workaround. |
This would certainly help us. The PR seems valid, could this be merged into the codebase please? |
or @gracekarina maybe |
Any news on this one, many projects are waiting to support PHP 8.1 as without this, it triggers deprecations. |
@HugoMario maybe you could help me to merge the PR? The PHP maintainers do not seems to reply. Thanks in advance! |
ping @frantuma maybe |
@char0n @gracekarina @ponelat @frantuma could anyone help us to merge this PR? |
@BafS in the meantime you can rebase the branch so that Let's hope that a core contributor will be able to have a look and merge this one soon as it's a real pain currently for PHP >= 8.1 and will become more and more annoying as PHP 8.2 is near to be released. |
Thanks for your patience folks, from my limited knowledge of PHP, |
@ponelat thanks for your feedback. |
Thanks! |
Thank you! Do you know when the next release will be tagged? |
@frantuma any chance to create a new tag to have the release available to the world? |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
Add
#[\ReturnTypeWillChange]
(https://php.watch/versions/8.1/ReturnTypeWillChange) to avoid deprecation notices.Fixes #11820
cc. @dkarlovi and @mandrean