Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #42 - overwrite body and name as well #106

Merged
merged 1 commit into from
May 23, 2023

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented May 22, 2023

No description provided.

@svenstaro svenstaro merged commit 42c6380 into svenstaro:master May 23, 2023
3 of 6 checks passed
@robertsLando
Copy link

robertsLando commented May 31, 2023

This has broken all my builds.... I always used this action to upload assets in existing releases and this change made all my releases body empty. I would suggest to revert this change and make this opt-in instead, or at least, release this as a major release explaining the breaking change

@regevbr
Copy link
Contributor Author

regevbr commented May 31, 2023

I think that the fix is to check if the body/name are not empty, and overwrite them only in that case, will that solve your case?

@regevbr regevbr deleted the body_update branch May 31, 2023 07:43
@regevbr
Copy link
Contributor Author

regevbr commented May 31, 2023

see #108

@robertsLando
Copy link

Could be an alternative

@ovr
Copy link

ovr commented May 31, 2023

This has broken all my builds.... I always used this action to upload assets in existing releases and this change made all my releases body empty.

👍

It's a breaking change. If this action follows semver, it should be done differently.

From README.

overwrite: If an asset with the same name already exists, overwrite it (Default: false).

☝️

@svenstaro
Copy link
Owner

svenstaro commented May 31, 2023

True, I did see it as a bug fix at the time but now I see that users depended on that old behavior. At any rate, let's get this fixed quickly. I haven't received any feedback on #108. Does that work for you guys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants